[https://codepen.io/SkyeGideon/full/QWNrbLw]
My first project on FCC, Am done with it already but I did not know about the forum in my rookie days hence why am sharing it this late, Any feedback would be appreciated.
1 Like
Hi @skyeparagon!
I think your page looks good. A few things to consider.
-
The Caption titled Great Grace Hopper is positioned at the far right hand side. It might be nice to place that underneath the image. When you resize the browser window to be smaller the text disappears.
-
You have a few errors in your html page. I would run the html analyzer in codepen to address those issues. The main one is using single quotes for attributes. It should be double quotes.
-
The HTML
<br>element produces a line break in text (carriage-return). It is useful for writing a poem or an address, where the division of lines is significant. (MDN definition) . I would use css instead to create space between paragraphs.
Hope that helps!
Happy coding!
Your page looks good @skyeparagon. Some things to revisit;
- Do not use the
<br>element to force line breaks or spacing. That’s what CSS is for.- If you want multiple paragraphs then use mulitple paragraph elements.
- The image caption gets “lost” on smaller screens and doesn’t appear correctly on larger ones.
Notice it over to the right of the container.
