Tribute Page - Friends: The Reunion

Hi Freecodecampers, I would like to hear some feedback from you. :+1:

Also, the page may be informative for those who want to refresh their memory of the famous tv series.

Hi!

Why don’t you use other color relate to Friends? Like red, blue or yellow. It could look more colorful.

Hi @Edgar29 !

I think your page looks good.

It looks like one of your images is not loading.
Screen Shot 2021-06-04 at 9.01.52 PM

I would also review the lesson on giving links meaningful names.
imdb page is not that accessible.

1 Like

Your page looks good @Edgar29. Some things to revisit;

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in the HTML editor. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
  • Run your HTML code through the W3C validator.
    • There are HTML syntax/coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Codepen provides validators for HTML, CSS and JS. Click on the chevron in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for CSS is good. Use it and address the issue(s).
    • (The one for HTML misses things which is why I recommend W3C)
  • We do not have access to your google acc’t therefore cannot see the picture hosted there.
    • You can search and find places that offer free image hosting. Or you can link to an image hosted elsewhere like you did the others.
  • Accessibility is about being accessible to all users. Review the giving meaningful text to links lesson. For a more thorough explanation read Web Accessibility in Mind.
    • imdb page” is not accessible
  • Make your page responsive. Remember, the R in RWD stands for Responsive
    • There’s a horizontal scrollbar on smaller screens. Images are falling out of the container on smaller screens.

1 Like

because i wanted minimalistic design, not too colorful

Hi, thanks for your advices. I have some problems with last two advice.Can you give me example how can i make my link accessible and short in this situation?
Can you help me with responsive images. I changed width of my last three images and now cant make them responsive. There is no scrollbar anymore but images not good looking when i resize. Thanks for your time,Also ive posted my second project check it if you have time. Survey Form-Market Research

Thanks, Can you give me example how can i make my link accessible and short in this situation? `Also i have posted my second project check it if you have time. Survey Form-Market Research

There were two links provided in the feedback regarding making links accessible. The second one is better. Did you read it? Was there something you did not understand?

I don’t see where the widths have been changed.

Please open a new topic for feedback on your survey form.

Hi, I have 5 images on my page. For the last three of them i changed width using max-width/min-width properties. Now the are not responsive.
How should i change images size make it responsive at the same time???

Yes, i have just opened

CSS line 60-64 article .class

Yes i understood it. But i have this text

For more information about special episode and cast visit [imdb page] i know that accessible in this line is “more information about special episode and cast” but i thin it is too long for link. How can make accessible and short at the same time?

If you set a min-width the image can shrink so don’t do that, or make it a very small number (e.g. if the device is 320px maybe 200px or so).

You have this:

article .small {
  min-width: 800px;
}

If you set a max-width in px you have to also have width: 100% on the image.

article .phoebe {
  max-width: 800px;
}

img {
  /* this get overwritten by the above selector */
  max-width: 100%;
  
  height: auto;
  display: block;
  margin: 0 auto;
  
  /* you need this */
  width: 100%;
}
1 Like

The image worked for me.

1 Like

That post is from 7 days ago. Don’t you think something might have changed since then?

Like they fixed a host issue perhaps?

1 Like

Why not just say " To learn more about this special event, check out Friends: The Reunion imdb page"
Or something to that effect.
The link could be Friends: The Reunion imdb page
That would be more descriptive then imdb page.

1 Like

Hello there, @Edgar29

Let’s talk about responsive images. I don’t totally agree with the approach of using “max-width”, but I understand. If you have an image bigger than the container, the image will shrink adapt to the width of the container, but the same thing doesn’t happen if the image is small than the container. For that “width 100%” will solve the case but can cause a problem, when you stretch an image more than the original size the image will lose quality, and you don’t want that in most cases. Depending on how much is the stretch or the purpose of the image some loss of quality can be acceptable.

So what makes the image responsive “width 100%” or “max-width 100%”? Neither of the two, these properties will make the image be fluid/liquid, you can research about “fluid/liquid design” it is halfway to understanding the “Responsive design”. To really do image responsive you will need a different approach like you do different CSS to different breakpoints in media queries you will provide different image souces with different sizes to each breakpoint, that’s is how you truly do and gain performance. Because there is no sense you load gigantic images in devices with a small screen does it?

You can learn more about this here.

MDN > Elements > Picture

1 Like

That`s a good idea, thanks!

Thanks, great advice. So i need different images for different screen sizes.

thanks, i`ll try to fix it

One remark. I set min-width because some of my images,with class small, are smaller than the others. So if i set min-width small number its width will not be equal to the others. But i`ll try to solve this using media querries.