Tribute page - George Hotz

Code Feedback
1

https://codepen.io/_Lev/pen/poNVXZx

Here is my tribute page for the first project. I tried to keep it close to the original to save some time.

Any tips/feedback would be greatly appreciated. :slight_smile:

Also, english is a second language to me so there might be mistakes here and there.

2

Welcome to the forums @MaxLev. Your page looks good. Some things to revisit;

  • Run your HTML code through the W3C validator.
    • There is an HTML coding error you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Codepen provides validators for HTML, CSS and JS. Click on the chevron in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for CSS is good. Use it and address the issue(s).
    • (The one for HTML misses things which is why I recommend W3C)
  • Accessibility is about being accessible to all users. Review the giving meaningful text to links lesson. For a more thorough explanation read Web Accessibility in Mind.
    • “twitch” and wikipedia entry" are not accessible
  • Use a contrast checker. The links are very hard to see. Light text on a light background is a bad UX. (See screenshot)

Your project should be original. The sample is just one way to do the project. The instructions say yours should be functionally similar and to give it your own style. Start the project from scratch, with your own code, style and content. Don’t take code from the sample project.

Screen Shot 2021-03-02 at 18.36.41