Tribute page Goku

Code Feedback
1

Hi, guys, I’m new in coding I just made a tribute page about Goku this is the link: https://codepen.io/andreibri/full/qBaQVoZ
Tell me what you think about it

1 Like
2

That is awesome :joy: :fire:. If I could change one thing, it would probably be the main font colour. The contrast isn’t great with the background which makes it a bit hard to read. Great job man, I finished this a few weeks ago and yours is a lot more colourful and vibrant.

3

yeah, but to be honest I don’t know which colour put to don’t have that contrast :joy:

4

Try adding:
overflow-x: hidden;
to the body
:smiley:

5

Took the time to check that and the overflow on the X-axis is mostly being caused by the headers.

6

Your page looks good @andre98briceag. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>)
    • The test script should be included, with all tests passing, when you submit your projects.
    • Your page passes 4/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue. (Be sure and read more than just the first line of the failing message.)
  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in HTML. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • For instance links to fonts go in the box labeled ‘Stuff for <head>’
  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Codepen provides validators for HTML, CSS and JS. Click on the chevron in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for CSS is good. Use it and address the issue(s). You have some duplicate property: value; pairs
    • (The one for HTML misses things which is why I recommend W3C)
  • Accessibility is about being accessible to all users. Review the lesson about giving meaningful text to links. For a more thorough explanation read Web Accessibility in Mind.
    • “goku” is not accessible
  • Make your page responsive. Remember, the R in RWD stands for Responsive
    • There’s a horizontal scrollbar on large and small screens
  • overflow-x: hidden; will completely hide anything that extends outside its container element horizontally. It’s recommended to not do this, and refactor your CSS to be more responsive - otherwise it is possible for your site to appear to be missing content.
  • Don’t be afraid to be descriptive with class and id names. It’ll be more semantic for yourself, and others who read your code. For example, if you have several cryptic id's that make sense to you now, they may not a year later and probably will never mean anything to other people.
  • Maybe run your color choices through a contrast checker.
1 Like
7

I tried but the problem it saying to me is that I give the wrong name of some id but for me is easier to give the name of one id I want other ways I will forget the code.

I tried my code here: https://validator.w3.org/nu/#textarea
and it’s saying no CSS and HTML problem but when I try the FCC page to run the test it’s saying me only 7/10 so wich one I have to follow?

8

I don’t understand what this means.

The only thing you should be pasting in the W3C validator is your HTML code. It will give you any errors in your HTML. As I said, since you copy/paste from codepen you can ignore the first warning and first two errors.

The validator has nothing to do with FCC’s test script. That is the one that will give something like 7/10.
This is saying how many of the user stories were successfully met when you created your page. It looks as though you may have made some code changes because now you are passing 7/10 user stories. Once again, click the red button to see which test(s) are failing and text to help you correct the issue. (Be sure and read more than just the first line of the failing message.)

So, you can code a page that meets all the user stories but there are syntax errors in HTML. The W3C validator will show that.
You can code a page that doesn’t meet all the user stories but the HTML is correct. The FCC test suite shows you that.
You can code a page that has syntax errors and doesn’t meet all user stories. That’s why you use the W3C validator and the test suite.

1 Like
9

what fun, awesome job!!

maybe try adding a background-color to your paragraph and an opacity to help with your text being a bit easier to read.

1 Like
10

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.