Tribute page : GSP

Hi guys.

Just finished my first tribute page.
Tried to make it look similar to the template provided.

Tribute Page

Any feedback is welcome :slight_smile:

Cheers!

Don’t you want to pass the tests? Or, did you just want to implement that style?

Wanted to implement that style, wasn’t really following the guide.

1 Like

Welcome to the forums @anluke. Your page looks good. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>)
    • The test script, with all tests passing, should be included when you submit your projects.
    • Your page passes 2/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
    • Be sure and read more than just the first line of the failing message. The ability to read and comprehend error messages is a skill you’ll need to acquire as a developer. Ask questions on what you don’t understand.
  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in the HTML editor. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • For instance links to fonts go in the box labeled ‘Stuff for <head>’
  • Accessibility is about being accessible to all users. Review the giving meaningful text to links lesson. For a more thorough explanation read Web Accessibility in Mind.
    • wikipedia entry” is not accessible

The sample projects are not templates. They are samples, one way to do the project. The instructions say to make yours “functionally similar” and to “give it your own personal style”.

You make the font smaller for smaller devices. It makes it harder to read.

Having long sentences stretch from one side of the screen to the other is tiring on the eye and makes things harder to read.

When using semantics you wouldn’t include the footer in the main element. I realize the user story says the page “should have an element with a corresponding id="main", which contains all other elements” but the element containing that id doesn’t have to be the main element.

1 Like

Thanks for the feedback, appreciate it :slight_smile:

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.