Tribute Page https://codepen.io/overdosse/pen/RExyJN

What you guys think about…>>>>>>>>!?

Hi there!

Here are some things I have noticed :+1:

You want to be careful about mixing inline styles and external styles.

For example here

style="width:700px; height 500px;"

Reason being is that this could lead to a situation where you have inline styles for an element and then also try to style that same element in your external css stylesheet.
The inline styles will override the external stylesheet and this could lead to a frustrating debugging situation if you were expecting a certain set of styles but received another.

I would move all inline styles over to the css section.

In your anchor element make sure you use the correct attribute name

target="_black"

For your img elements, make sure to include alt attributes.

It looks like you are referring some bootstrap styling

<div class="col-xs-12">

But I don’t see that added in your css settings

You have some repetition in your css here

h1{
  text-align: center;
  padding-bottom: 10px;
  color: green;
}
h2{
  text-align: center;
  color: green;
  padding-bottom: 10px;
}

Remember that you can combine css selectors that share the same style by sepserating the selectors with commas.

h1, h2 {
styles go here
}

I would suggest running the analyze function for both your css and html.
Also using the format tool in codepen

Hope that helps!

1 Like

Thank you for your time and verification
I had no way of knowing, I’m just getting started.
I will note this information :slight_smile:

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.