Tribute Page - my first project

Hey there! Just started the first course on freeCodeCamp this week and started my first project . Took me 4,5 hours to complete it. What do you think?

https://codepen.io/mosakay/pen/gOLjgOO

Hi there,
Nice job. Your page looks good. Just a couple things I noticed.

  1. When you shrink the viewport, your image spills over its div. I think using 50rem rather than a percentage for max-width is causing this.

  2. Your padding/margin settings for your timeline make the text very narrow, especially for smaller screens.

2 Likes

Welcome to the forums @Mosakay. Your page looks good. Some things to revisit;

1 Like

@nikhilreddy.manda, I don’t want to hijack another’s thread but just want to say;

  1. don’t have others compare their page to yours or have them style like yours. each page is unique to the coder
  2. your page does not pass all user stories so it’s not a good example for others to follow.

Thank you for your feedback!
I’ve done some changes for smaller devices, I think now should be fine

@media only screen and (max-width: 768px) {
#image {
max-width: 25rem;
}
#tribute-info {
margin: 5px 5px;
}
}

@Roma appreciate it! I ve done some changes as well for the a tag

1 Like