Tribute-Page (Opinion)

Here is my entry for the Tribute page project. If there is anyway it can be improved I’m open to hear them, thanks.
My Tribute Page

Looks good. Here’s a couple of suggestions:

  1. Having the width of the content span the whole screen makes it harder to read. So you might want to limit the width for #tribute-info and then center it.

  2. Increasing the line-height will also make it easier to read.

  3. Another thing that will increase readability is if you add some padding to the <li>s.

Thanks for the advise, the line height made a significant change. Forgot to add that.

Your page looks good @ErrorCode. Some things to revisit;

  • Run your HTML code through the W3C validator.
    There is an HTML syntax/coding error you should be aware of and address. (review and try and understand why the p element closes when you use the ul element. also, does the ul element need to be nested in the p element?)
    Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Accessibility is about being accessible to all users. Review the giving meaningful text to links lesson. For a more thorough explanation read Web Accessibility in Mind.
    biography” is not accessible
  • Keep all your styling external. Do not use in-line styling
  • Is this font-family: time new roman; a valid font?
    Also it’s recommended that family names containing whitespace be quoted
  • Is the value here valid? font-style: italics;

On a side note, have you noticed that hovering over #img-div causes a horizontal scroll bar?

1 Like

Thank you so much for your advice and opinion. I really appreciate it. You can help check the code again and see if there is anything more you would like to add or correct

Meanwhile if anyone still have any advice, opinion or suggestion I’m open to hear them

It looks good @ErrorCode. Nice job cleaning things up.

One thing I would suggest is using a contrast checker. In your tribute-link the dark blue on a dark background is hard to see.
(On a side note, you can remove the words “click here to” and just leave the link text.)

1 Like

Thanks a lot, I appreciate it. Never knew there were a lot of checkers. I finished my survey form project and it would be nice if you check it out also. Thanks in advance.

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.