Hi all; I just finished my first challenge which was to make a tribute page
need your feedback please
here is the github code and the Live Solution
Welcome to the forums @Dev-Martinien. Your page looks good. Some things to revisit;
- When asking for feedback please post your project in the #project-feedback subforum. I’ve taken the liberty of moving this for you.
- Accessibility is about being accessible to all users. Review the giving meaningful text to links lesson. For a more thorough explanation read Web Accessibility in Mind.
- “wikipedia” is not accessible
thank you for your feedback @Roma ; I reread the course and understood correctly.
I modified my code and I hope I fixed the problem.
another feedback would be welcome, thanks
Really liked your tribute page. I am also a beginner but I like how short and sweet it was although I found the text to be too much BUT all the text was informative and really learned alot. Stay blessed
First of all the best critic you can get. I actually started reading. The design was enhancing the content. You did not let the design take over. Good!
Though you may increase the readability further by limit the text length so that the eyes find the next line easier.
Much better! Further enhancement is to break up long paragraphs into “sections”. Sort of “catch my breath”. Just add CSS
p {
margin-bottom: 10px;
}
…to <p>
element and divide long sections into logical “pauses”.
logical section 1 There are many variations of passages of Lorem Ipsum available, but the majority have suffered alteration in some form, by injected humour, or randomised words which don't look even slightly believable. If you are going to use a passage of Lorem Ipsum, you need to be sure there isn't anything
logical section 2 There are many variations of passages of Lorem Ipsum available, but the majority have suffered alteration in some form, by injected humour, or randomised words which don't look even slightly believable. If you are going to use a passage of Lorem Ipsum, you need to be sure there isn't anything
I also suggest <strong>
as a “sub headline” at the beginning of each section.
Very good work. Congrats. I do not have too much feedback to give. Only two small nuances.
- In the sub-title Created JavaScript. Co-founded Mozilla and Firefox. It would be better to put: "He created JavaScript and Co-founded Mozilla and Firefox. "
- Instead “Piitsburg”. Pittsburgh.
Great job!
This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.