Tribute Page Projec Feedback

With a feedback done I did everything from the scratch and it’s here right now every code is my code. Can I get a feedback and how should I improve it?

HI @berkaykrl !

Just a few things to consider.

I think content should be inside the main tags.
Right now, you have it like this which also has a small syntax error in it.

<main id="main" class=headerlol </main>

You should place all of your content inside the tags.

<main id="main" class="headerlol"> 

CONTENT GOES HERE
</main>

You can’t have multiple ids in elements like this

id=image id=header-img

You should just use one id per element.

You have a few other errors.
Run your code through the html validator

You have a small error in your css.
Use the codepen analyze tool to find and fix that error.

Hope that helps!

1 Like

@berkaykrl, in addition to the feedback you’ve received,

  • The test script, with all tests passing, should be included when you submit your projects.
    • Your page passes 9/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
      Be sure and read more than just the first line of the failing message. The ability to read and comprehend error messages is a skill you’ll need to acquire as a developer. Ask questions on what you don’t understand.
      You’ve been given the answer. You need to incorporate it.

As mentioned, run your HTML code through the W3C validator and correct the issues.

1 Like

Thank you it looks like fixed now and now I notice that myself fixing it really helped it since it looks smoother to me :slightly_smiling_face: passes all the scoring now