I’ve just finished my first project!
I learnt a lot!!!, I had fun with css and I started to use Css Grid and Media Queries in order to make it a little bit responsive, I think I need to improve the accessibility and the classes name.
I wrote some unnecessary code in order to pass the test, my image is a background in Css and I had some problems with the test because of the img tag and so on.
what do you think?
You did great! I loved “Into the Wild” Good job on the grid, the layout shifts appropriately on smaller sizes.
I think the way you styled the H2 element under the image, one would expect a Eddie Veddier-quote in there or some lyrics, rather than more information. Just a suggestion!
In the .content2-div with all the text, I’d consider some left and right padding so that the text doesn’t go all the way out to the edges. For these longer paragraphs, I think justifying to the left is usually preferred. I’d also increase line-height to make it look a bit nicer and increase readability.
I see that you’re using
<br> after H2 to get some air between your paragraphs. I think this is considered bad practice, and the way to go is to, for instance, increase margin-bottom on the upper element.
On the 700px break-point, the empty space above the “Eddie Vedder” header looks a bit odd, so consider reducing that slightly
But all in all, great job! Keep going!
wow! , Thank you so much for your feedback, I’m gonna make the changes, I really appreciate it.
Your page looks good @aldhair.escobar. Some things to revisit;
- When using codepen it only expects the code you’d put within the
<body> </body> element in HTML. (No need to include the body tags). For anything you want to add to
<head> click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
- The link to your font would go in the box labeled ‘Stuff for <head>’
- Don’t use the
<br> tag to force spacing. Use margin and/or padding in CSS.
- Review the lesson about giving meaningful text to links.
Thank you so much!!, I already finished, I like how it looks
I think the image of the subject should not be coded as a CSS background it should be in the HTML
The image should be part of the structure and not part of the design.
you can design it using CSS but not as a div background