Tribute page project feedback

I really appreciate any feedback. This is my second little project with FCC. Thank you :slight_smile:

Hi @hetauda

figcaption elements are usually nested in figure elements.

When using the alt attribute, and make sure to add spaces instead of underscores to separate the words.

Also, on line 12 you have an empty img element.

If you want to create line breaks, consider using the br element, or using the padding element.

Happy coding

2 Likes

HTML:

Is this for creating line-breaks?

             <p></p>
            <p></p>

Use <br> as @Teller suggested, or add margins/padding (top/bottom as needed) to your paragraph <p> tags.

CSS:

I would move the a, a:active , and a:hover to the top of your CSS, with other element styles that could appear throughout.
This way, you’re keeping your elements’ styles together, followed by your more specific ( higher specificty ) styles , like those for ids next, in order.

However, keeping the footer, which is an element, at the bottom would be fine, as it is a layout element and always appears (or should) at the bottom.

I’m guessing you put the anchor tag styles at the bottom because that is where they appear on the page currently. They could appear all over in a bigger project, so it would be good practice to have them near the top. This way you create an overall CSS reset before you move into specifics ( specifying classes and ids ).

1 Like

Thank you so much. I made all the changes you suggested! Very helpful :slight_smile:

1 Like

Thank you for mentioning how to organise CSS elements. I was just adding them without thinking about it to much. Very helpful tip!

1 Like