Tribute Page Review - Mike Royko

Tribute Page Review - Mike Royko
0

#1

Appreciate any feedback on my tribute page. Thanks. Project Link - [https://codepen.io/ssypek/full/aLxdyW/]


#2

@stanne Great start here! You’re using bootstrap successfully and your HTML markup is clear and easy to read.

I like your use of the <footer> and <figure> semantic elements. You can also use <main>, <header>, and <section> elements if you want. These semantic elements really help people using screen readers and search engines find the content their looking for. Here’s more info: https://internetingishard.com/html-and-css/semantic-html/.

You may want to modify your colors so they pass contrast checks. Here is your background color and text color: https://webaim.org/resources/contrastchecker/?fcolor=E79F5C&bcolor=F0EAD2. I use this tool a lot to make sure my colors are contrasting nicely.

Some of your CSS is repeated:

h1{
  ...
  font-weight: bold;
  color: #e79f5c;
  font-family: 'Tangerine', serif;
}
  
h2{
  ...
  font-weight: bold;
  color: #e79f5c;
  font-family: 'Tangerine', serif;
}

You may want to move this into its own class instead of repeating it.

I see some inline styles in your HTML. Some people say this should be avoided whenever possible. Here’s more on that if you’re interested: https://www.thoughtco.com/avoid-inline-styles-for-css-3466846.

You may find some more helpful edits by entering your HTML code here in this validator: https://validator.w3.org/nu/#textarea.

Other than that, you’re off to a great start! :fireworks:


#3

@camper thanks a lot for the review. Appreciate the pointers, and I’ll be sure to go through the links you provided. Really appreciate it!


#4

@camper I’ve already submitted this as my project. Is it ok to go back and make changes to it, or is a submitted project final?


#5

@stanne As far as I understand, submitting the project to FCC is basically adding a link to your project to your FCC profile. You can see the link to that project on your FCC profile page here: https://www.freecodecamp.org/stanne. I think it’s expected that one will update the projects as needed and as one learns more.