Tribute Page: Son Heung-Min

Code Feedback
1

Here’s my Tribute Page:
https://codepen.io/heejjiinn/pen/zYvxdmP

2

Very Nice all that’s left is for you to add media queries and make it mobile responsive

2 Likes
3

This is awesome!! Nice job! Couple to point out is generally <a> tags should have a title attribute. Also, even though an id has a greater specificity than a class, you want to only style classes and leave id’s for manipulation.

1 Like
4

Also to add onto this, accessible HTML (having extra things like anchor tags having a title attribute or an image needing an alt attribute to show alternative text to describe the image) is for example, blind people who use screen readers and navigate the internet that way. Important to learn the basics? Probably not, but really good to know as you are moving forward!

1 Like
5

Your page looks good @heejjiinn. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>).
    • Your page passes 5/10 user stories.
    • The test script should be included, with all tests passing, when you submit your project.
  • Run your HTML code through the W3C validator.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
    • There are other errors you should clean up.
  • Review the lesson about giving meaningful text to links.
1 Like