Tribute page21-project feedback

Code Feedback
1

I made a tribute page on chatrapati shivaji mahraj now i want to you guys visit my project and give feedback

2

Hello welcome! I saw your project and I leave you the following tips:
-The title align it in the center.
-In the description of the tribute you could have used an element “p” instead of “h5”.
-In the link I see that the use of an “h4” was unnecessary, on the other hand “Wikipedia Entry” is not very accessible, try to improve it by a more descriptive phrase.
-Try to change the font family.
-Give a little more style, change the background color for example.
I hope my opinion serves you!
Regards!

2 Likes
3

sure i will definitely try to fix that
thanks for feedback

4

Looks good!
It’s a small thing but you might consider:

#tribute-info{
  padding: 10px;
}
#img-caption{
  padding: 10px;
}

Really just preference though :slight_smile:

1 Like
5

okay i will …
bytheway thanks for feedback ^-^

1 Like
6

Hi @sammm29!

I think it would be nice if you put the picture always on a way that the user don’t need to scroll the page to see it all. Like adding:

max-height: 70vh;

for example.

7

sure i will do it bro…
thanks for feedback buddy… :slightly_smiling_face:

1 Like