Tribute to Kobe Bryant

Code Feedback
1

http://tribute-page.s3-website-us-east-1.amazonaws.com/

1 Like
2
  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>).
    • The test script should be included, with all tests passing, when you submit your project.
  • Review the lesson about giving meaningful text to links.
3

Hi @tsabunkar!
I like the clean design. Here are some of my recommendations:

  • You shouldn’t skip headers: after <h1>, there should be an <h2>; if your main preoccupation is styling, you can just use <p> and then css to make it smaller/larger;
  • It’s recommended to use semantic html, and so instead of <b>, it’s better to use <strong>; and instead of <i>, it’s better to use <em>;
  • I love that you are using <figcaption>! In this manner, you could also use <figure> instead of the <div> it is located in (again, semantic html);
  • The div with the class “timeline” could be <section class="timeline"> (semantic html);
  • <h4> could become a <p> tag to not skip headers — just style it with css!

I hope this helps!

4

Hi @sylwiavargas , why not to skip de <h*> tags?

5

Skipping headers makes your page less accessible (and it hurts SEO, as well).

You can read more on that here:

2 Likes
6

I didn’t know that.
Thanks for the answer, i really appreciate it.

2 Likes
8

Thank for your valuable feedback , I will surely incorporate them.

1 Like
9

Thanks for your feedback.

I have incorprated test cases script in codepen : https://codepen.io/tsabunkar/pen/eYNEwLg

1 Like
10

Also, I would be glad if you can also provide feedback on my following assignments.
Thank you for your valuable time.

http://forum.freecodecamp.org/t/techincal-documentation-page-on-vuejs/367973
http://forum.freecodecamp.org/t/personal-portfolio-tejas/367974

1 Like