Twitch Streamers - FCC Frontend Challenge

Code Feedback
#1

This one got me crazy . Since I had to fetch each streamer data seperately I had to write a complex function to do that. And the filter option also made me crazy. After so many coffee I finished it . Any feedback or better ways to do the fetching and filtering will be appreciated. Here is the link to the project Codepen

2 Likes
#2

Hi @adramelech !

Looks like a cool project.

The only thing I noticed was this direct DOM manipulation.

I am not a professional react dev but I heard that direct DOM manipulation like this is a no no.

 document
        .querySelectorAll(".btn")
        .forEach((btn) => btn.classList.remove("active"));
      document.getElementById(condition).classList.add("active");

It’s giving me vanilla js vibes :grinning:

#3

Hey Jessica ,Thank you for your valuable suggestion . I have changed my code , take a look

1 Like
#4

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.