URL Shortener Not Passing Tests

[PCWCFA]

Here’s my URL shortener https://fcc-urlshortener.pcwcfa.repl.co/api/shorturl. The tests state that the last three of the four tests do not pass. I see for example that the test www.example.com should respond with an {error: ‘invalid url’}, and my app is doing so. By the way, the res.json automatically puts double quotes around both the key and the value, so the actual response is {“error”: “invalid url”}. I hope this is the cause of the tests not passing.

[Philip_B]

I’m not as far as you are in the FCC curriculum but found this older post;

URL Shortener Microservice (Error that i cannot figure out )

When I use your post field on the home site, it makes a POST to https://frosted-tough-temple.glitch.me/api/shorturl/new and with the data url: https://www.happyhatsforkids.org/, it returns with a 200, {"original_url":"https://www.happyhatsforkids.org/","short_url":"607e1f77d3766f00af52bbaa"}. So, that seems to work. However … the first failing test says: You can POST a URL to /api/shorturl and get a JSON response with original_url and short_url properties. Here’s an example: { original_url : …

[kevinSmith]

@PCWCFA

By the way, the res.json automatically puts double quotes around both the key

Right, that isn’t an issue. The double quotes show up because it is being converted to JSON, where all properties and string values are wrapped in double quotes. It won’t matter how your JS object is written (single/double quotes, quotes around properties or not), it will always end up the same in JSON.

I see for example that the test www.example.com should respond with an {error: ‘invalid url’}, and my app is doing so.

Is it?

This is the response I’m getting on your page.

{"original_url":"http://www.example.com","short_url":20}

And when I try to run the test suite and look at the network tab of the browser dev tools (which you should learn how to do), I see that you are getting CORS errors for those tests:

You’ll need to figure out how to handle that.

[PCWCFA]

Thanks. I’ll look into that.

[PCWCFA]

Thanks. I’ll check this one out as well.

[PCWCFA]

Kevin,

I see the CORS error as well. I found the root cause. I had moved the below line from the boilerplate to the end, so the tests couldn’t access my server.

app.use(cors());

[PCWCFA]

I do have one remaining question about the final test using http://www.example.com. I realized the reason for why I was able to get {error: “invalid url”}. It was because I had a trailing space after the URL in my own test. When I typed in the correct http://www.example.com sans the trailing space, I see that the response is that it is a valid URL. However, I don’t think this is an error because both the dns-lookup and my opening a new tab shows that http://www.example.com is now a valid site. I believe the test needs to be updated to use an invalid site. Ex: http://asdfasdfasfdasdf.

lookup err null address 2606:2800:220:1:248:1893:25c8:1946

[kevinSmith]

Sorry, I didn’t read that closely enough:

If you pass an invalid URL that doesn’t follow the valid http://www.example.com format, the JSON response will contain { error: 'invalid url' }

The issue is if it doesn’t fit that pattern. If you open up the network tab, you can see the actual invalid url that is being used to test. Or just pass it jibberish.

But it seems a moot point now because you seem to be passing.

[PCWCFA]

Kevin,

Thank you for taking the time to respond. It was very helpful.