Whether or not something is “intuitive” is relative. The more you use it, the more comfortable it becomes. I would agree that it is slightly less “readable” in that it combines two “steps” into one, it takes a couple extra seconds of reading.
Which is better? It depends. The reduce function is slightly more efficient (one pass through the data) . Is that better? To give up a little bit of readability for a little bit of efficiency? Again, for me, that depends. If I can wrap that in a well-named function that does only that so it is completely clear what it does, then to me, the reduce solution is better. If it is in the flow of code and I am worried that it may not be obvious what it is doing, I might go for the two step solution. Besides, 99.99% of the time, that difference in performance won’t matter.
should I try to understand both solutions and solve the problem in as many different ways as possible, not just this challenge but to form a learning habit?
I think that is a great learning strategy. I often do that, after finishing an algorithm challenge, figure out how other people solved it.
Specifically on reduce it is very cool and powerful but often frighten’s off learners. I think it is the hardest one for learners to master. But it also can do really cool things when used well.
You should take the effort to understand how it works: it can be very useful. Every other array method can be implemented using reduce, it’s quite powerful.
Yes, I have a linting rule in my current codebase at work that forbids use of reduce unless it’s just being for adding up an array of numbers, it will flag any usage of the method and suggest using a for…of loop instead
That made me laugh. I think that’s a bit extreme, but I do agree that you can create some rather arcane an impenetrable code with reduce. But I usually just wrap the callback into a well-named function.
But yeah, it can get a little awkward in some usages. I can understand why people might want to avoid it. Where I’m working now, they prefer methods, putting an emphasis on declarative programming.
Haha, it’s part of a package of eslint rules I added to help with making sure ESModules worked, which also a load of preferences based on newer features + simpler code. I turned off a load of them but ended up keeping the reduce one after one of the other developers got completely stuck on some reducer logic I’d written that I thought was relatively simple. So far, haven’t found anywhere that couldn’t be rewritten in a much simpler form. But I tend to find that I rarely need to chain methods together, map/filter/flatMap are normally all I need. If it weren’t the case reduce would be more useful but
Edit: IME when doing anything complicated with reduce it often ends up shoehorning complicated logic into a the quite specific recursive callback, into quite a small space. Can do filter/map/etc first, but I tend to end up writing a single function that does the operation
I’ve edited your post for readability. When you enter a code block into a forum post, please precede it with a separate line of three backticks and follow it with a separate line of three backticks to make it easier to read.
You can also use the “preformatted text” tool in the editor (</>) to add backticks around text.
I also wrapped it in [spoiler][/spoiler] tags since it is a working solution to a curriculum challenge.
Can you use an extra variable there. Sure? Is there anything wrong with that? Maybe a little. It is an unnecessary variable. The function name should imply that it is returning an array so it is a little redundant. I think things like sonar would flag that as unnecessary. It’s not the end of the world, but it it’s basically a one statement process that’s being spread into two statements, one could argue that it is unnecessary. It’s not a huge sin, but a tiny one, perhaps, at least according to some.
I’d say the name of the variable is the bigger issue, not so much the variable itself.
It might be redundant no matter what, but that is doubly true if it also provides no useful information. The name newArr is pretty useless as we know both filter and map return a new array. If it at least signified what it contained it might have some purpose, although as said the function, in this case, can provide that information.
If you had saved the result of filter out into an intermediate variable it might have provided information about what the filter is doing.