Weather-app project - Feedback

Code Feedback
1

Hi!

I have just completed my weather app project.

I am still trying to find out an appropriate way to build layouts without spending so much time on aligning and justifying elements on them.
Any kind of comments will be appreciated.
Thanks in advance!

2

The weather for my location does not show an icon for the current weather (as shown in the screen shot below). After further investigation, it is because you are referencing weather[0].icon, but there is no icon property for weather[0]. See bottom for the json data.

image
image778×608 121 KB

JSON data

{
  "coord": {
    "lon": -121.92,
    "lat": 37.4
  },
  "weather": [
    {
      "id": 502,
      "main": "Rain",
      "description": "heavy intensity rain"
    },
    {
      "id": 701,
      "main": "Mist",
      "description": "mist",
      "icon": "50n"
    }
  ],
  "base": "stations",
  "main": {
    "temp": 16.78,
    "pressure": 1013,
    "humidity": 100,
    "temp_min": 16,
    "temp_max": 18
  },
  "visibility": 4023,
  "wind": {
    "speed": 1.23,
    "deg": 184.503
  },
  "clouds": {
    "all": 90
  },
  "dt": 1523071140,
  "sys": {
    "type": 1,
    "id": 409,
    "message": 0.1708,
    "country": "US",
    "sunrise": 1523108636,
    "sunset": 1523154961
  },
  "id": 5373327,
  "name": "Milpitas",
  "cod": 200
}
3

Hello Randell,

Thanks a lot for your feedback. After doing some tests I figured out that the API I was using does not deliver any data in the icon field for some cities, so I changed of API and now it seems to we working well.

Let me know in case you have another comment.

Best regards,

Renzo

4