Webpage Feeback

Code Feedback
1

Hi guys. So this is a project that I have been working on for about a month to add to my portfolio (I went in thinking that it would be done in 7 days!). Lately, I have stepped away from this project though, and have just come back to take it out of the dusty closet.

It is nowhere near the completeness that I had intended it to be, but I think that if I stick with this project until it is perfect, it will never be done. Also, the time that is spent on this project will be better spent on others, and learning new things. I will continue to do pit-stops though to add new things here and there as I learn new stuff.

In the meantime, I would like to hear your feedback and this one, and tips on improvements that could be made - please bear in mind though that I am trying to mirror the original webpage for the most part.

Some of the major shortfalls that I have noticed while working on this project is:

  1. I need to get familiar with a CSS naming convention such as BEM.
  2. The layout of the HTML is not as ‘efficient’ as I would like it to be. I found this out later while creating the stylesheet. As such, I found myself repeating some rules and classes that could have been avoided (the CSS file is bloated).
  3. Documentation

Also, you may notice that the CSS selectors are very wordy. This is because that CSS file is from an Scss output.

Original webpage

My copy

2

cool work, look exactly same as original , including “header and footer” section

  • search functionality seems bit off, it simple takes me to an external link, rather than letting me use search option
  • search view also could do some polishing
  • subscribe button’s alignment in that div could be better
  • same for Save Article button
  • sidebar “scolbar” height is limited to a certain height
  • in original site there were “Pets” section at bottom, i suppose you decided not to include that in your attempt

good job, happy coding :slight_smile:

1 Like
3

Thank you! I will look into and work on these :+1: