What's wrong in this code: profile lookup

Tell us what’s happening:

function lookUpProfile(name, prop){

// Only change code below this line

for(var x = 0; x < contacts.length; x++){

    if(contacts[x].firstName === name){

           return contacts[x][prop] || "No such property";

    } else return "No such contact";

}

// Only change code above this line

}

Your code so far


// Setup
var contacts = [
{
    "firstName": "Akira",
    "lastName": "Laine",
    "number": "0543236543",
    "likes": ["Pizza", "Coding", "Brownie Points"]
},
{
    "firstName": "Harry",
    "lastName": "Potter",
    "number": "0994372684",
    "likes": ["Hogwarts", "Magic", "Hagrid"]
},
{
    "firstName": "Sherlock",
    "lastName": "Holmes",
    "number": "0487345643",
    "likes": ["Intriguing Cases", "Violin"]
},
{
    "firstName": "Kristian",
    "lastName": "Vos",
    "number": "unknown",
    "likes": ["JavaScript", "Gaming", "Foxes"]
}
];


function lookUpProfile(name, prop){
// Only change code below this line
for(var x = 0; x < contacts.length; x++){
if(contacts[x].firstName === name){
       return contacts [x][prop] || "No such property";
} else return "No such contact";
}
// Only change code above this line
}

lookUpProfile("Sherlock", "likes");

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.97 Safari/537.36.

Challenge: Profile Lookup

Link to the challenge:

Hello~!

This line is inside your for loop, meaning if the first contact doesn’t match the name, it returns “No such contact”. :slight_smile:

1 Like

I’ve edited your post for readability. When you enter a code block into a forum post, please precede it with a separate line of three backticks and follow it with a separate line of three backticks to make it easier to read.

Please use the “preformatted text” tool in the editor (</>) to add backticks around text.

See this post to find the backtick on your keyboard.
Note: Backticks are not single quotes.

markdown_Forums