Why does this code not work?

Can anyone tell me why this code fails the first three tests, namely:

“Kristian”, “lastName” should return “Vos”
“Sherlock”, “likes” should return [“Intriguing Cases”, “Violin”]
“Harry”,“likes” should return an array

It has something to do with the positioning of the line - else {return “No such contact”} -, because when I position this down a line outside of its current curly brackets, then it works, but I don’t see why this should be the case.

Your code so far


// Setup
var contacts = [
{
    "firstName": "Akira",
    "lastName": "Laine",
    "number": "0543236543",
    "likes": ["Pizza", "Coding", "Brownie Points"]
},
{
    "firstName": "Harry",
    "lastName": "Potter",
    "number": "0994372684",
    "likes": ["Hogwarts", "Magic", "Hagrid"]
},
{
    "firstName": "Sherlock",
    "lastName": "Holmes",
    "number": "0487345643",
    "likes": ["Intriguing Cases", "Violin"]
},
{
    "firstName": "Kristian",
    "lastName": "Vos",
    "number": "unknown",
    "likes": ["JavaScript", "Gaming", "Foxes"]
}
];


function lookUpProfile(name, prop){
// Only change code below this line
for(var i=0; i<contacts.length;i++){
if (contacts[i].firstName==name){
    if (contacts[i].hasOwnProperty(prop)){
        return contacts[i][prop];
    }
    else {return "No such property"}
}
else {return "No such contact"}
}

}
// Only change code above this line


lookUpProfile("Akira", "likes");

Your browser information:

User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.122 Safari/537.36.

Challenge: Profile Lookup

Link to the challenge:

Ask yourself at what time exactly "No such contact" should be returned and check whether your function does that at that expected point.

Hi, thank you for replying, I checked what you said but I still don’t see it.

Let’s take test 1: lookUpProfile(“Kristian”, “lastName”) should return Vos.

This is what I believe should happen when my code is run:

  1. for loop cycles through each object
  2. the loop gets to contacts[3]
  3. the first if statement checks if (contacts[3].firstName==“Kristian”)
  4. the statement is true, so runs code in curly brackets - another if statement:
  5. second/ nested if statement checks if contacts[3].hasOwnProperty(lastName)
  6. the statement is true, so runs code in curly brackets - return contacts[3][“lastName”], which is Vos
    7.rest of code should now be ignored right? and Vos should be returned, as test requires. so why does the test fail?

Actually I just worked it out, so nevermind! Thank you