I finished https://codepen.io/nimeshakya/pen/oNLaGVQ my first project (Tribute Page) according to the Curriculum.
I would really appreciate your reviews on my work.
Regards.
Hey @urfrenznimubro!
Congrats on your first project.
Just a few things.
-
I think the link at the bottom of the page should be blue so users know to click on it.
-
For codepen, you don’t need to include the html and head content. If you need to include that content then you can add it in the head section in the settings.
-
I ran your code through the html and css analyzer and there are a few issues that need your attention.
<!--attributes need double quotes not single-->
<div id='main'>
#about-container{
width:95%;
/*Duplicate margins*/
margin: 0 auto;
margin: 2rem; /*rem and em are used for font sizes not margin*/
}
Good job on your project!
Keep up the good work!
Hi @urfrenznimubro. Your tribute page looks good.
Here are some of my opinions:
- Add a little bit of margin above and below the headings and image
- Centre align the text in the footer
- Make the paragraph a little bit bigger for easier reading
Anyway, great job. I like it
Thank you for your reviews.
I’ll keep up the good work.
Your page looks good @urfrenznimubro. Some things to revisit;
- Accessibility is about being accessible to all users. Review the lesson about giving meaningful text to links.
- Web Accessibility in Mind has a more thorough explanation.
- “wikipedia” is not accessible
- Do not use the
<br>
element to force line breaks or spacing. That’s what CSS is for.
Hey @urfrenznimubro. Your page looks good.
Just a minor thing. As far as I know, you should provide an alt
attribute for the img
element not the div
element.
Thank you all for your reviews…
I’ll work on improving