Your Opinion about Product Landing Page

Code Feedback
1

Hi Campers!

Could you please give me your opinion about the product landing page I have just finished?
And One more question :slight_smile:
We are asked to put a video in the page to show the product specification or something like that. We were asked to use ‘video’ tag, I did it using iframe tag and mentioned the video tag with its required ID only to pass the test.
So, anyone here did it using only video tag? How does it work with youtube?

Product Landing Page link:
Product Landing Page

Thanks in advance

2

Hi! Pretty clean design, I like the hover effects :slight_smile: And it’s responsive, so good job on that. Your video, though, is a bit too short in height so it looks a bit odd on desktop devices.

As for your other question, <video> tag is usually used to upload videos from your own resources and host them on your website. If you want to ember a video from another website (like YouTube), you should use <iframe>. As far as I can see, you’ve got both in your HTML, so if you try to delete the <iframe>, you’ll see that the video disappears, but if you delete the <video> tag nothing happens (so my advice is to do it in order to keep your code clean). Hope this helps! :slight_smile:

1 Like
3

Thanks for your time :slight_smile:
I added the iframe tag for myself to keep myself motivated, and I added the video tag with an id to pass the exam only. I’ll consider deleting it though.
Regarding the video tag, I thought we were asked to use it to display a youtube video because that what was displayed in the page we were asked to imitate :slight_smile:
Thanks again for the clarification.

4

Actually, in the user story, we were only asked to ember a video with an id="video" attribute, they didn’t specify which tag you should use. So if you assign this id attribute to <iframe> you should still pass all the tests :slight_smile:

And you’re welcome, I’m glad I was able to clear some things up :slight_smile:

1 Like
5

:sweat_smile: I don’t know how I read it a ‘video’ tag!!
Thanks again for your feedback.

1 Like
7

nice job :yum:

  • maybe new font? :thought_balloon:
  • please go to pen settings -> html -> insert viewport meta tag -> save & close for responsiveness :iphone:
1 Like
8

Thanks Steffan, I just did … Yet I didn’t see the difference until I resized the window! What does that do?JS Technical Documentation

9
1 Like