Roman Numeral Converter | Javascript Project 2

[deetigupta8]

It is passing all the test.

[admit8490]

Sorry, maybe I misunderstood something.

I took the last version of code your posted:

@deetigupta8

Made it work by luck. But I Need more understanding around recursion, return.

const romanToArabic = {
  //Testing 1 to 10 numerals
  I : 1,
  IV : 4,
  V : 5,
  IX: 9,
  X: 10,
}


function convertToRoman(num) {
   let str = "";
  let numeralWithLeastDifference;

  for(let item in romanToArabic){  
    if(num === romanToArabic[item]){
       str += item;
       return str
    } 
     else if (num > romanToArabic[item]){
      numeralWithLeastDifference = romanToArabic[item]
      
     }  
  }
  //console.log(numeralWithLeastDifference)
 for (let item in romanToArabic){  
   if (numeralWithLeastDifference === romanToArabic[item]){
     str+= item
     num = num -  numeralWithLeastDifference;
     //str += 
      str += convertToRoman(num)
       console.log(str)
       return str
     
   }
 } 
  
}

convertToRoman(29);

I tested it in FCC console.
It’s working for tests from
case 2
to
case 29

For bigger numbers tests are not passing.
So I am little bit confused when you’re saying it’s passing all the tests.

[deetigupta8]

So, i didn’t paste the entire object list here. That’s why those tests weren’t passing for you. Sorry!!

[admit8490]

Oh, no worries, I get it now