Big problem with ' in URL

1

Hi all!
I’m try resolve task with Random Quote Machine and i have problem.
Than i generate href attribute for twitter link (post quote to tweet) and in quote exist " ’ " symbol in the URL his transfor to ’ code and my URL crash. How fix it?

Sorry for my bad english.

2

Use encodeURIComponent().

3

Can anyone pls help me with my Random Quote machine ?
Here is link to my pen : https://codepen.io/danegit/pen/Bdyvrd?editors=1010

4

It’s bad idea because then text look’s like this “& #8217;s a sign you aren& #8217;t doing anything very innovative.”

Why this construction replace only first ’ ??

var str = a[0].content.slice(3, -5).replace("’", ‘%27’);

5

Can you post a link to your project?

6

Yes. sorry.

7

I can fix this bug then i add in replace-function RegExp with key gi.

$(".fa-twitter").attr(“href”, “https://twitter.com/intent/tweet?text=” + str.replace(/’/gi, “%27”) + a[0].title);

Now in tweet i have normal string

8

OK, I’ve looked into this more, and it turns out there are several interesting/relevant things here:

  1. I stand by my recommendation — use encodeURIComponent() to encode strings to be used as values for parameters in URLs, because it’s designed for that specific purpose and it will catch problematic characters like ? and &.
  2. 'Straight single quotes' don’t actually need escaping in URL strings and will have no adverse effect (even though the official standard, RFC 3986, lists them as reserved characters).
  3. ‘Curly single quotes’, as with most other characters, should be escaped.

However, the root of your problem has nothing to do with any of this. The problem here is that the Quotes on Design API is returning strings that have already been optimized for HTML, meaning they contain HTML entities, including our friend ’ that’s causing you all this heartache.

Basically, you’ll need to find a way to unescape the HTML entities before encoding as a URI component. This should be elementary if you just want to deal with ’, and a little more involved if you want to catch every possible numerical entity.

1 Like
9

ok, i’m under stand!
Thank’s very much. I’m try to catch all HTML entities with loop and switch\case construction, i tihnk this simple and effective way.

10

Actually, I just found a sneaky workaround that’s both elementary and comprehensive:

Spoiler

$(".my-quote").text()

Source: https://stackoverflow.com/a/5796744/8318731

1 Like
11

OMG =)
It’s work!!

Thank’s)

12

No worries. I also learned a lot of new stuff! :grin:

1 Like