Build a JavaScript Calculator - tests won't pass

JavaScript
#1

Tell us what’s happening:
As far as I can tell, my calculator is passing the tests when I enter the calculations manually, but when I run the tests I only get 12/16.

Your code so far

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/106.0.0.0 Safari/537.36

Challenge: Front End Development Libraries Projects - Build a JavaScript Calculator

Link to the challenge:

#2

Really need help here. I tried to debug and it seems like after certain tests the display from the last calculation isn’t clearing properly with the clear button. When I do it manually, I have no issues.

#3

Hi @aharrington993!

You can click on the “x/x Passed” button to get more details about what test cases were run so it would be easier for you to debug.

Best of luck :wink:

#4

Thanks, I did look at the details but I can’t reproduce all of the errors manually.
For example: The sequence “5 + 5 = + 3 =” should produce an output of “13” : expected ‘9.55’ to equal ‘13’
When I put this in manually I get 13.

#5

Trying entering 5-9+1 and then hit the = button. You should get 1 but instead get -3.

#6

Switching to the old render method makes all but one test fail for me.

ReactDOM.render(<Calculator />, document.getElementById("root"));

The sequence “5 * - + 5” = should produce an output of “10” : expected ‘25’ to equal ‘10’

2 Likes
#7

Thank you! Never would have expected that.

#8

@lasjorg Why in React 18 do things have to have delays? Is React 18 that much faster than React 17?

#9

No, if anything it is the opposite, it is slower.

What if I don’t want to batch?

Usually, batching is safe, but some code may depend on reading something from the DOM immediately after a state change. For those use cases, you can use ReactDOM.flushSync() to opt out of batching:

#10

Thanks! This worked for me.

#11

Same. Spent a couple hours on this. Seems like the test cases could be updated because mine was failing because I believe it was reading in the final number entered into the calculator as the answer as opposed to the real answer that was calculated, as the function that actually calculates the answer takes place after it is pressed. Not sure, either way thank you so much!

I was using this method and it was failing:

const root = ReactDOM.createRoot(document.getElementById("root"));
root.render(<Presentational />);