Build a Pomodoro Clock - Feedback Please

I have completed the Pomodoro clock project in React.

Please take a look and let me have your feedback,

Thanks!
-G

Link to the challenge:

1 Like

Looks cool. I would stay away from the blue offset at the default screen. It looks blurry. I like the buttons, though.

Thanks for that, I have removed the text shadows now

1 Like

Good job. I was surprised to see that you made it in react. Love the buttons.

1 Like

Glad you liked it.

I had earlier done this project in JQuery using flipclock.js
Wanted to do it in React this time with flipclock-type of timer. But flipclock-type display turned out too complex for me, so had to leave that part out.

Wonder if someone else has done it here?

Your timer adds an extra second to both the session and break.

I was testing out your pomodoro clock and noticed a bug.

The bug is each timer (session or break) actual lasts one extra second longer than it should.

The example below assumes I set both the session and break time to 1:00 before clicking the start button.

What should happen

01:00 - starts in Session
00:59
00:58
.
.
.
00:03
00:02
00:01
00:00 - switch to Break
00:59
00:58
.
.
.
00:03
00:02
00:01
00:00 - switch to Session
00:59
00:58

What happens instead

01:00 - starts in Session
00:59
00:58
.
.
.
00:03
00:02
00:01
00:00 - technically once this is reach 60 seconds has passed
01:00 - switch to Break
00:59
00:58
.
.
.
00:03
00:02
00:01
00:00 - technically once this is reach 60 seconds has passed
01:00 - switch to Session
00:59
00:58

1 Like

I tried to implement the change as you suggested.

Instead of starting the subsequent timer at 1:00 I adjusted the code to start it at 0:59.
However this causes two test cases to fail - refer screenshot.

How to address this?

-G