Build a Sorting Visualizer - Build a Sorting Visualizer

JavaScript
1

Tell us what’s happening:

I’m failing Test 18. I’m not really even sure what to start looking for in my code for a root cause. I’m still struggling to really understand recursion and the processing of for… loops, especially when there’s 2 together like I used in this code. I admit I used an example I found online. Anyway, cheers and thanks for any insight.

Your code so far

<!-- file: index.html -->
<!DOCTYPE html>
<html lang="en">

<head>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <meta http-equiv="X-UA-Compatible" content="ie=edge">
    <title>Sorting Visualizer</title>
    <link rel="stylesheet" href="styles.css">
</head>

<body>
    <main>
        <div id="array-container">
            <div id="starting-array"></div>
        </div>
        <div id="btn-container">
            <button id="generate-btn" type="button">Generate Array</button>
            <button id="sort-btn" type="button">Sort Array</button>
        </div>
    </main>
    <script src="script.js"></script>
</body>

</html>

/* file: styles.css */
* {
    box-sizing: border-box;
}

main {
    height: 100vh;
    display: flex;
    justify-content: center;
    flex-direction: column;
    align-items: center;
}

#array-container {
    max-height: 95vh;
    display: flex;
    flex-direction: column;
    flex-wrap: wrap;
    gap: 2px;

}

#array-container>div {
    min-width: 8rem;
    height: 2rem;
    box-shadow: rgba(50, 50, 93, 0.25) 0px 2px 5px -1px, rgba(0, 0, 0, 0.3) 0px 1px 3px -1px;
    border-radius: 10px;
    margin-bottom: 0.2rem;
    border: 2px solid darkgray;
    display: flex;
    justify-content: space-evenly;
    align-items: center;
}

#starting-array {
    border: 4px solid darkblue !important;
}

#btn-container {
    display: flex;
    justify-content: space-around;
}

button {
    padding: 2px;
    margin: 5px;
}

span {
    border-radius: 2px;
    padding: 0.5px;
    margin: 0
}

@media (min-width: 430px) {
  #array-container>div {
    min-width: 12rem;    
  }
  span {
    padding: 1px;
    margin: 1px;
  }
}

/* file: script.js */
/******FUNCTIONS ********** */

const generateElement = () => Math.floor(Math.random() * 100) + 1;

const generateArray = () => Array.from({ length: 5 }, () => generateElement());

const generateContainer = () => document.createElement("div");

const fillArrContainer = (htmlEl, array) => {
  let arrayFill = ``;
  array.forEach((item) => {
    arrayFill += `<span>${item}</span>`;
  })
  htmlEl.innerHTML += arrayFill;
  return htmlEl;
}

const isOrdered = (int1, int2) => int1 <= int2;

const swapElements = (arr, index) => {
  if (!isOrdered(arr[index], arr[index + 1])) {
    let temp = arr[index];
    arr[index] = arr[index + 1];
    arr[index + 1] = temp;
  }
}
 
const highlightCurrentEls = (htmlEl, i) => {
  htmlEl.children[i].style.border = "2px dashed red";
  htmlEl.children[i + 1].style.border = "2px dashed red";
};

/******  GLOBAL ARRAY CONTAINER******* */
let myArray = [];

/*********** HTML ELEMENTS ************ */

const generateBtn = document.getElementById('generate-btn');
const sortBtn = document.getElementById('sort-btn');
const arrayContainer = document.getElementById('array-container');
const startingArray = document.getElementById('starting-array');

generateBtn.addEventListener('click', () => {
  arrayContainer.replaceChildren(startingArray);
  startingArray.innerHTML = ''
  myArray = generateArray();

  const fill = fillArrContainer(startingArray, myArray);
}) 
 
sortBtn.addEventListener('click', () => { 
  const startingArraySpans = startingArray.querySelectorAll('span');
  startingArraySpans[0].style.border = "2px dashed red"
  startingArraySpans[1].style.border = "2px dashed red"

  for (let i = 0; i < myArray.length -1; i++) {
    for (let j = 0; j < myArray.length - 1 - i; j++) {
      console.log(myArray)
      swapElements(myArray, j) 
      const container = generateContainer();
      const fill = fillArrContainer(container, myArray);
      arrayContainer.append(fill); 
      highlightCurrentEls(container, j);
    }
  }  
  console.log(myArray)
});

Your browser information:

User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/140.0.0.0 Safari/537.36

Challenge Information:

Build a Sorting Visualizer - Build a Sorting Visualizer

2
  • you’re asked to keep a ”div” with “starting array”
  • but here it seems either your’re doing something extra such as highlighting them, test cases might not be expecting them, may be trying without highlighting for starting array could work!
  • also, consider keeping “sort btn” disabled after sort is done, currently it keeps on making more divs

happy coding :slight_smile: