Build an Apply Discount Function - Build a Discount Calculator

[stonkemonkeman]

Tell us what’s happening:

my code does pass the tests but its saying its not

Your code so far

def apply_discount(price,discount):

    if not isinstance(price,(int,float)):
        return("The price should be a number")

    elif not isinstance(discount,(int,float)):
        return("The discount should be a number")

    elif price<=0:
        return("The price should be greater than 0")

    elif discount<0 or discount>100:
        return("The discount should be between 0 and 100")

    discount=price*(discount/100)
    price=price-discount
    print(price)


apply_discount(100, 20)
apply_discount(200, 50)
apply_discount(50, 0)
apply_discount(67,100)
apply_discount(74.5,20.0)

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/145.0.0.0 Safari/537.36

Challenge Information:

Build an Apply Discount Function - Build a Discount Calculator

freeCodeCamp.org

[ILM]

are you sure that your function is doing what is requested? is it always returning something?

you have return here

@stonkemonkeman

return("The discount should be between 0 and 100")

but print here

@stonkemonkeman

print(price)

[Mr_Dynamite]

try the final block with else statement indenting it appropriately. It might work

[ILM]

hi @Mr_Dynamite

It is great that you solved the challenge, but instead of posting your full working solution, it is best to stay focused on answering the original poster’s question(s) and help guide them with hints and suggestions to solve their own issues with the challenge. How to Help Someone with Their Code Using the Socratic Method

We are trying to cut back on the number of spoiler solutions found on the forum and instead focus on helping other campers with their questions and definitely not posting full working solutions.

[Asiya31]

change print(price) to return(price)