Build an Apply Discount Function - Build an Apply Discount Function

Curriculum Help
1

Tell us what’s happening:

what wrong with these codes?
def apply_discount(price, discount):
if price != (int or float):
return ‘The price should be a number’
if discount != (int or float):
return ‘The discount should be a number’
if price > 0:
return ‘the price should be greater than 0’
if discount < 0 and discount > 100:
return ‘The discount should be between 0 and 100’
if price and discount:
return price - (price *(discount / 100))

Your code so far

def apply_discount(price, discount):
    if price != (int or float):
        return 'The price should be a number'
    if discount != (int or float):
        return 'The discount should be a number'
    if price > 0:
        return 'the price should be greater than 0'
    if discount < 0 and discount > 100:
        return 'The discount should be between 0 and 100'
    if price and discount:
        return price - (price *(discount / 100))

apply_discount(50, 0)

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/149.0.0.0 Safari/537.36

Challenge Information:

Build an Apply Discount Function - Build an Apply Discount Function

GitHub Link: freeCodeCamp/curriculum/challenges/english/blocks/lab-discount-calculator/695774002591bbc5f8cf3e53.md at main · freeCodeCamp/freeCodeCamp · GitHub

2

Hey @talk2olamy,

Try printing a few different cases: a valid price, an invalid discount, and a discount of 0, and see if each output matches what the user stories expect.

For example:

print(apply_discount(100, "abc")) // invalid discount
print(apply_discount(50, 0)) // discount of 0
3

Hi @talk2olamy,

Please review this theory lecture again, which talks about using type(), and at the bottom, isinstance(). What is doesn’t show is that isinstance() can take a tuple as the second argument so you can check two or more types at once.

Understanding Variables and Data Types - What Are Common Data Types in Python and How Do You Get the Type of a Variable? | Learn | freeCodeCamp.org

Happy coding