Challenge tribute page

Code Feedback
1

https://codepen.io/Rehan1/pen/ExVPoeP

Here is my tribute page. Give me some feedback on it. Thank you!

2

Hey, one thing that jumps out at me right away is that I can barely read your content. You do want people to be able to read it, right :slight_smile: Your font color needs to be much darker on that white background. You can check for color contrast accessibility at https://webaim.org/resources/contrastchecker/.

2 Likes
3

https://codepen.io/Rehan1/full/ExVPoeP

Hey, thank you for the feedback i have used a darker grey which gives it a good contrast above is my edited one

4

you also need to have the test suite included in the project you submit to freecodecamp

5

when i reduce the size of my browser i have to scroll horizontally to see the full page try to optimize it for mobile viewing as well

6

I have tried it but it don’t seem to work its confusing me!!

7

Your page looks okay @rehanh285. Some things to revisit;

  • Your page passes 8/10 user stories.
    • To start, delete everything in your #image { } declaration and review the lesson on make an image responsive
    • As you work through this pay attention to each of the failing tests as fixing one may cause another similar one to pop-up
  • Don’t use the <br> tag to force spacing. Use margin and/or padding in CSS
  • You need to work on responsiveness for the blockquote
  • It’s hard to read your timeline because it’s centered. It would look better and read easier if it were maybe aligned left
  • Review the lesson about giving meaningful text to links.
1 Like
8

I am currently working on the page trying to make it more responsive keep you updated on it thank you!

1 Like