Change = {status: “INSUFFICIENT_FUNDS”, change: []};

Code Feedback
1

change = {status: “INSUFFICIENT_FUNDS”, change: };

I would expect this uncommented test to return insufficient funds
as it is I’m passing 3 out of the 6 test
but due to how javascript handles decimals
I’m afraid I’ve lost scope of where I have scaled up or down 2 digits
and where it affects a conditional comparison

CashRegister, fork the CodePen

capturecashregisterinsufficientfunds
`
function checkCashRegister(price, cash, cid) {
let total = cid.map(currency => currency[1]*100).reduce((total, amount) => total + amount);
let totalINdrawer = total/100; //use reduce method to sum the 2nd property of an array, do not use a loop
console.log('totalINdrawer = ',totalINdrawer);
let changeDue = cash - price ;
totalINdrawer = total / 100;
//changeDue = changeDue * 100 ;
let change = ‘’;//set default return
console.log('9 change = ', change);
console.log('10 changeDue = ',changeDue);
console.log('11 totalINdrawer = ',totalINdrawer);
if (totalINdrawer == changeDue ) {
change = {status: “CLOSED”, change: cid};
}//end of if (totalINdrawer == changeDue )
else if (totalINdrawer < changeDue) {
change = {status: “INSUFFICIENT_FUNDS”, change: };
console.log('17 change = ',change);}//end of// else if (totalINdrawer < changeDue)
else {// (totalINdrawer > changeDue) …so calculate change
//calculate change object here
let romanString = ‘’;
while (changeDue > 0){
switch (true) {
// hundreds
case (changeDue > 99):
romanString = romanString.concat(‘ONE HUNDRED’);
changeDue = changeDue -100;
break;
// twenties
case (changeDue > 19):
romanString = romanString.concat(‘TWENTY’);
changeDue = changeDue -20;
break;
// tens
case (changeDue > 9):
romanString = romanString.concat(‘TEN’);
changeDue = changeDue -10;
break;
// fives
case (changeDue > 4):
romanString = romanString.concat(‘FIVE’);
changeDue = changeDue -5;
break;
// ones
case (changeDue > 99):
romanString = romanString.concat(‘ONE’);
changeDue = changeDue -100;
break;
// quarters
case (changeDue > 24):
romanString = romanString.concat(‘QUARTER’);
changeDue = changeDue -25;
break;
// dimes
case (changeDue > 9):
romanString = romanString.concat(‘DIME’);
console.log('56 romanString = ',romanString);
changeDue = changeDue -10;
break;
// nickles
case (changeDue > 4):
romanString = romanString.concat(‘NICKLE’);
changeDue = changeDue -5;
break;
// pennies
case (changeDue > 0):
romanString = romanString.concat(‘PENNY’);
changeDue = changeDue -1;
break;
default:
console.log('70 changeDue = ',changeDue);
}//end of switch
}//end of while…
console.log('73 changeDue = ',romanString);
// return romanString;
// totalINdrawer = totalINdrawer * 100;
console.log('76 totalINdrawer = ',totalINdrawer);
//changeDue = changeDue * 100 ;
console.log('77 changeDue = ',changeDue);
if (totalINdrawer < changeDue) {
// changeDue = changeDue * 100 ;
//denominations not suffeicent, do not compute, as in 2 quarters in drawer, to convert to a dime, nickle & pennies)
change = {status: “INSUFFICIENT_FUNDS”, change: };
console.log('80 change ',change);
}
else { //just give his money bruh
// changeDue = changeDue / 100 ;
change = {status: “OPEN”, change: changeDue};//calculate denominations of change…
console.log('84 change = ',change);
}// end of else, give him money bruh
}//end of else, give change as per calculation
console.log('86 change = ', change);
return change;} // Here is your change, ma’am.//end of function checkCashRegister(price, cash, cid)

//console.log(‘3.26, 100’);
//checkCashRegister(3.26, 100, [[“PENNY”, 1.01], [“NICKEL”, 2.05], [“DIME”, 3.1], [“QUARTER”, 4.25], [“ONE”, 90], [“FIVE”, 55], [“TEN”, 20], [“TWENTY”, 60], [“ONE HUNDRED”, 100]]); //{status: “OPEN”, change: [[“TWENTY”, 60], [“TEN”, 20], [“FIVE”, 15], [“ONE”, 1], [“QUARTER”, 0.5], [“DIME”, 0.2], [“PENNY”, 0.04]]}.
//console.log(‘19.5, 20’);
//checkCashRegister(19.5, 20, [[“PENNY”, 1.01], [“NICKEL”, 2.05], [“DIME”, 3.1], [“QUARTER”, 4.25], [“ONE”, 90], [“FIVE”, 55], [“TEN”, 20], [“TWENTY”, 60], [“ONE HUNDRED”, 100]]); //should return {status: “OPEN”, change: [[“QUARTER”, 0.5]]}.
// checkCashRegister(19.5, 20, [[“PENNY”, 0.01], [“NICKEL”, 0], [“DIME”, 0], [“QUARTER”, 0], [“ONE”, 0], [“FIVE”, 0], [“TEN”, 0], [“TWENTY”, 0], [“ONE HUNDRED”, 0]]); //should return {status: “INSUFFICIENT_FUNDS”, change: }.

console.log(‘19.5, 20’);
checkCashRegister(19.5, 20, [[“PENNY”, 0.01], [“NICKEL”, 0], [“DIME”, 0], [“QUARTER”, 0], [“ONE”, 1], [“FIVE”, 0], [“TEN”, 0], [“TWENTY”, 0], [“ONE HUNDRED”, 0]]);
// should return {status: “INSUFFICIENT_FUNDS”, change: }.

// checkCashRegister(19.5, 20, [[“PENNY”, 0.5], [“NICKEL”, 0], [“DIME”, 0], [“QUARTER”, 0], [“ONE”, 0], [“FIVE”, 0], [“TEN”, 0], [“TWENTY”, 0], [“ONE HUNDRED”, 0]]); // should return {status: “CLOSED”, change: [[“PENNY”, 0.5], [“NICKEL”, 0], [“DIME”, 0], [“QUARTER”, 0], [“ONE”, 0], [“FIVE”, 0], [“TEN”, 0], [“TWENTY”, 0], [“ONE HUNDRED”, 0]]`

2

This challenge is a bit misleading.
In this case there are sufficient funds BUT the cash register does not have the correct denominations remaining.
Try to test for this situation.

My solution after all other tests are done, ends with:

   // Handle denomination for exact change not available
   if (changeLeft > 0) {
     return 'Correct change not available';
   }