Check if an Object has a Property vol.2

JavaScript
1

Tell us what’s happening:
Hi, I’ve resolved this challenge and I can see there are other solutions available on the forum; I was wondering if you could help me see what’s wrong in this solution of mine.
I can’t fulfill the last condition , “The function isEveryoneHere returns false if Alan, Jeff, Sarah, and Ryan are not properties on the users object”. Thanks.

Your code so far


let users = {
  Alan: {
    age: 27,
    online: true
  },
  Jeff: {
    age: 32,
    online: true
  },
  Sarah: {
    age: 48,
    online: true
  },
  Ryan: {
    age: 19,
    online: true
  }
};

function isEveryoneHere(obj) {
  // change code below this line
var a = obj;
for (a in users) {
 return users.hasOwnProperty(a) ? true : false
  // change code above this line
}

console.log(isEveryoneHere(users));

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 Safari/537.36.

Link to the challenge:
https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/basic-data-structures/check-if-an-object-has-a-property

2

You’re checking only the first user in users, since return will return immediately.

3

I just realized there was a mistake in my code. My solution is

function isEveryoneHere(obj) {
  // change code below this line
var a = obj;
for (a in users) {
 return users.hasOwnProperty(a) ? true : false
  // change code above this line
}

How could this be modified so that it would check the whole length of the object? Thanks!

4

There must be a better way though than mine
cheers

5

Return exits the function. So you will exit after the first item this way.

The test asks you to return true if all items pass, that means this should be your default return.

Since return exits early, how else could you approach this?

6

yeah, is there a way to make this work please?

I get the feeling that it’s just something our of order but I don’t know. Have been at it for hours…

Got another solution but this one would be much better. Thanks!!

7

If you’re using the same code as OP, then slowly reread the instructions and this thread.