Failing test # 2 & 3 of URL Shortner Freecodecamp


For some odd reason, I can not clear test 2 and 3 of this project. I have ‘console logged’ the issue in my code, both the keys {original_url & short_url} return appropriate values as per the requirements.

The ( /api/shorturl/<short_url>) also redirects me to the value of my {original_url}. Not quite sure what the issue is.


Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/92.0.4515.159 Safari/537.36

Challenge: URL Shortener Microservice

Link to the challenge:

This first issue is that you are storing the shortened links in an array in the program and not in a database. As long as the one program is running and it’s the only program that’s running, that’s fine, but this will fail anytime the program is restarted. It may pass the tests this way, but you really need to tie into a DB, especially since you’ve already started some of the work to tie in MongoDB.

Second, you’re not logging enough. You had one place where you logged successfully validated URLs. I ran a fork of your project, and nothing was logged, which means there were no validated URLs. When I added some logging to your project like:'/api/shorturl/', (req, res) => {
  const {url } = req.body;

  const noHTTPSurl = url.replace(/^https?:\/\//, '');

  // check if url is valid

  dns.lookup(noHTTPSurl, (err) => {
    if(err) {
      console.log("everything is invalid");
      return res.json ({
        error: 'Invalid URL'

it logged
everything is invalid
everything is invalid
everything is invalid

So your validation is not working. It removes (some of) the protocols and the separator, but does nothing with the URL parameters, and hence does not return a hostname required by dns.lookup(). To give you an idea of how I would log the other route to debug, here is my version of your code:

  app.get('/api/shorturl/:id', (req, res) => {

    const {id} = req.params;
    const link = links.find( l=>l.short_url === id);

    if(link) {

      return res.redirect(link.original_url);
    } else {
        error: 'No short url'

      return res.json ({
        error: 'No short url'

which produces

{ id: 'undefined' }
{ error: 'No short url' }

This is actually expected since the other route is not actually returning an ID so there is no ID for the fCC tests to send.

1 Like

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.