Hello guys,
here is my first attempt at this tribute page project:
What do you all think?
Thank you in advance!
Nicola
Hello guys,
here is my first attempt at this tribute page project:
What do you all think?
Thank you in advance!
Nicola
It looks good but "1. The <img> element should responsively resize, relative to the width of its parent element, without exceeding its original size."
Change
image{
max-widt.....
}
to
img {
max-widt...
}
Try using margin: auto;
at your img
@Stranicola Your page looks nice but few things to revisit:
All of your user stories are not passing. Fulfil the user stories and get all of the tests to pass.
Analyze your HTML and CSS, like this:
Run your HTML code through the W3C validator . There are HTML coding errors you should be aware of. Since copy/paste from codepen, you can ignore the first warning and first two errors.
Inline CSS is not recommended.
I think that you should reduce the left or right space of the tribute info container so that it looks better. It’s my personal opinion. Otherwise, do whatever you like.
Do not use the <br>
element to force line breaks or spacing. That’s what CSS is for.
Keep it up!
Happy Coding!
Thank you for your help,
i have edited and set the max-width to the img in css.
Thank you for your help!
Welcome to the forums @Stranicola. Your page looks good. Some things to revisit;
ul
element, do not use the <br>
element to force line breaks or spacing. That’s what CSS is for.This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.