Finished JavaScript calculator using React

Code Feedback
1

Hi everyone. I finished my calculator. You can look at codepen.io. I would appreciate anyone who will test and evaluate my work.

2

wow that’s awesome nice try i really like what you’ve done back there thumb’s up

3

Here you go then:
injashkin your calculator:

I think its better if you change the color of the equal sine.
When you make an account, the calculator shows the final value twice.
About the division by 0 I say you the same thing that I said to stel: When you divide by 0 you can’t say is infinite, because currently its not defined if is infinite or other thing, so my advice is when you divide something by 0 put “Its not possible to divide by 0”.

4

Thanks for feedback! I was doing a project functionally similar to the https://codepen.io/freeCodeCamp/full/wgGVVX. There is also repeated twice the final value. As for zero, I agree, it needs to be changed. Although on the link the result is - infinity. I don’t bother with color. The main thing is functionality.

5

Nice job! :+1:

  • For mobile stuff, please go to pen settings -> html -> insert viewport meta tag -> save & close.
  • On the display with what you typed, IMO the background should be a bit lighter:
    DeepinScreenshot_select-area_20190927212250
    :thinking:
  • On the buttons, what about a different border? :smiley: Maybe 1px solid white?
  • Great job! :tada:
6

Thank You Steffan153.
As far as I understand, I have to enter the following: <meta name="viewport" content="width=device-width, initial-scale=1">?.
How about this background?
Screenshot_2019-09-28%20Javascript%20Calculator
With the boundaries of the buttons I have not yet figured out, as they automatically sets Bootstrap. Can someone tell me?

7

Wow! Impressive functionality and style!

I love how you space you calculator’s buttons. Your colors are really great, too.
If you could put a green space at the top of the calculator’s screen to hide the previous step, that’d be great.

8

Sorry, forgot to update the code. How now?

9

Yes. :slight_smile:

Actually bootstrap does not set the button styles, since you didn’t use Bootstrap classes on it. Simply set border: 1px solid white on buttons.

Nice. :sunglasses:

10

When I do so, disappears the effect of pressing.

11

Anyone tell me why on the website http://projects.jinv.ru/projects/calculator/index.html this calculator has large numbers and buttons
Screenshot_2019-09-29%20Javascript%20Calculator
and here codepen.io labels on buttons small
Screenshot_2019-09-29%20JavaScript%20Calculator(1).