He height of the welcome section should be equal to the height of the viewport

Hi there!

Can someone please help me with the last test of the Personal Portfolio Webpage?

I keep failing user story #10: The height of the welcome section should be equal to the height of the viewport.

I’ve used #welcome-section {heigth: 100vh;}
But I keep failing the test.

See codepen for my code:

I’ll be forever grateful for your help :love_you_gesture:

1 Like

When a test fails click the red button to see which test(s) are failing and text to help you correct the issue.

  • Be sure and read more than just the first line of the failing message. The ability to read and comprehend error messages is a skill you’ll need to acquire as a developer. Ask questions on what you don’t understand.

The failing message says

The height of the welcome section should be equal to the height of the viewport.
The height of #welcome-section is not equal to the height of the viewport : expected 422 to be close to 419 +/- 0
AssertionError: The height of #welcome-section is not equal to the height of the viewport : expected 422 to be close to 419 +/- 0

You’ve got two things going on that you need to revisit;

  1. There’s a border added to the #welcome-section…or not one really. Not sure what you were trying to accomplish
  2. There’s a section selector after the #welcome-section selector that’s adding padding. Remember that the C in CSS stands for Cascading. The #welcome-section is also a section.
1 Like

you have padding that is being added to the height

look up the box-sizing css property for minimum change

1 Like

Thank you so much! This was a very clear explanation. I think I understand now what went wrong. Will try to read my code again and try to fix it. For now, many thanks. Will update post when code is fixed.

Thank you for the link and answer! Will try to read and fix my code after absorbing the info you’ve provided.

Thank you untill eternaty! Your clear explanation helped a lot to understand the error message.

1 Like

Happy to help and glad you were able to get things figured out.

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.