Help Needed on Roman Numeral Converter Project

JavaScript
1

I’m working on Roman numeral converter project.

My code

 function convertToRoman(num) {
     
var thou = ["","M", "MM", "MMM", "MMMM"];
var hund = ["", "C", "CC", "CCC", "CD", "D", "DC", "DCC", "DCCC", "CM "];
var tens = ["",  "X", "XX", "XXX", "XL", "L",            "LX", "LXX", "LXXX", "XC"];                                          
var ones = ["", "I", "II", "III", "IV", "V", "VI","VII","VIII","IX"];                                                           
var t = thou[Math.floor(num/1000)]; 
var h = hund[Math.floor((num%1000)/100)];
var te = tens[Math.floor((num%100)/10)];
var on = ones[Math.floor(num%10)];
  var rom = t + h + te + on ;      
     
 return rom;
}

convertToRoman(36);

My code is returning correct for every condition except the last one(3999). I don’t know what’s the problem is. Please help.

2

what code is used for he thousands?

3

var t = thou[Math.floor(num/1000)];

I don’t know why its not showing on my post. Its present there.

4

there was a line break missing, I edited your post to add it in

let me check again your code

5

your output is MMMCM XCIX, there is an extra space, where could it come from?

1 Like
6

Thank you so much. I corrected it. Now it works fine.

7

next time you can add yourself the function to the editor and see what’s the output :slight_smile:

1 Like
8

Sure I will do. Thanks for the help. :grinning: