Help with viewport error

Hello, I am almost done with the portfolio project but I keep getting this error in the test
“The height of the welcome section should be equal to the height of the viewport.”
I tried to change the viewport height to 100 but I keep getting the same error.
Can some one tell what I am doing wrong please? Also, any feedback is welcome :slight_smile:

Here is the link ->
https://codepen.io/carlaicd/pen/gyXPzx

I think it’s because you have that padding-top of 45vh on your welcome-section. By default, the height you give to an element is applied to its content-box, and if you have any padding then it is added on top of that. It’s kind of dumb. To fix this, you can change the box-sizing property of your elements to border-box, like so:

* { box-sizing: border-box; }

And of course, don’t forget to set welcome-section height to 100vh;

https://developer.mozilla.org/en-US/docs/Web/CSS/box-sizing

1 Like