How to build a product landing page

Code Feedback
1

I build a product landing page for leaf spring
Check the preview and tell me where i should improve on.

The code: https://codepen.io/Raffaello-Josef/pen/zYXWGyK

2

Hi @mozieraphael

Just had a quick look at your page and code.

The logo is covering part of the heading.

image

The frameborder property for iframe is obsolete. Consider using css.

For lists, use li elements, not i with br, or span

Overall the layout looks nice.

Happy coding

3

Hi thanks for your advice… The i element was a typo … but i will correct it… thank you once again

1 Like
4

One thing I notice a lot in your HTML is the way you’ve written eveyrthing. The indentation on each line is a little bit all over the place which makes things a little bit hard to read for other people. You need to practice good indetation and organisation of your HTML.

The CSS looks pretty good. However, I did find a few mistakes like when declaring your “btn” class, you only typed “btn” missing out the period (it should’ve been “.btn”) causing all the CSS properties in that declaration not to be applied. Be really careful about these mistakes.

Overall though, your site looks pretty good! Well done!

5

Yh i do notice it too. I will try harder next time

1 Like
6

Just a comment when using codepen, you shouldn’t paste your whole html page, just what goes inside the <body> tags.

1 Like
7

alright… noted :+1: .
I didn’t know it works like that