Javascript Profile Lookup Help [SOLVED]

Javascript Profile Lookup Help [SOLVED]
0

#1

Hello

I know there are a lot of topics about this challenge, but even after I looked it up I still don’t know what is wrong with my code. Here is the challenge:

  • We have an array of objects representing different people in our contacts lists.
  • A lookUpProfile function that takes firstName and a property (prop) as arguments has been pre-written for you.
  • The function should check if firstName is an actual contact’s firstName and the given property (prop) is a property of that contact.
  • If both are true, then return the “value” of that property.
  • If firstName does not correspond to any contacts then return “No such contact”
  • If prop does not correspond to any valid properties then return “No such property”

Here it is the code:

//Setup
var contacts = [
    {
        "firstName": "Akira",
        "lastName": "Laine",
        "number": "0543236543",
        "likes": ["Pizza", "Coding", "Brownie Points"]
    },
    {
        "firstName": "Harry",
        "lastName": "Potter",
        "number": "0994372684",
        "likes": ["Hogwarts", "Magic", "Hagrid"]
    },
    {
        "firstName": "Sherlock",
        "lastName": "Holmes",
        "number": "0487345643",
        "likes": ["Intriguing Cases", "Violin"]
    },
    {
        "firstName": "Kristian",
        "lastName": "Vos",
        "number": "unknown",
        "likes": ["Javascript", "Gaming", "Foxes"]
    }
];


function lookUpProfile(firstName, prop){
// Only change code below this line
for (var i = 0; i < contacts.length; i++) {
    if (firstName === contacts[i].firstName) {
      return contacts[i].hasOwnProperty(prop) ? contacts[i][prop] : "No such property";
    } else {
      return "No such contact";
    }
  } 
  
// Only change code above this line
}

// Change these values to test your function
lookUpProfile("Kristian", "lastName");

When the function is invoked with the provided arguments (“Kristian”, “lastName”), it returns “No such contact”.

My code passes these tests:

However, I don’t understand why it doesn’t passes the others. Can anyone give me a hint?

Thanks a lot


#2

You only check the first contact in the array because you always return in your for loop. As soon as a return is hit, the function is exited.


#3

So, I should return “No such contact” AFTER the for loop has ended. I’ll try that


#4

Thanks a lot, @ArielLeslie. FCC marks this challenge as solved. Here it is the solution I found with your help:

function lookUpProfile(firstName, prop){
// Only change code below this line

  var result = "";
  for (var i = 0; i < contacts.length; i++) {
    if (firstName === contacts[i].firstName) {
      return contacts[i].hasOwnProperty(prop) ? contacts[i][prop] : "No such property";
    } else {
      result = "No such contact";
    }
   }
return result;
  
// Only change code above this line
}

Regards