Landing page project fix

HTML-CSS
1

Hey!
I am fixing my landing page project and I’m pretty happy with it now.
but - I still didn’t pass due to 2 problems:

  1. When I click a .nav-link button in the nav element, I am taken to the corresponding section of the landing page.’
  2. The navbar should always be at the top of the viewport.
    I tried a lot of different things and I still don’t pass even tho it’s all working well.
    https://codepen.io/Ayamir/pen/jOrRxZM

I also trying to get the submit button to change it color when the computer mouse on it like I did in the nav but it’s not working for some reason.
ill be happy to receive any extra feedback as well…
thank you!

2

Hello there,

Here is the error message:

Each .nav-link element should have an href attribute : expected false to equal true

Here is your code:

<li class="nav-link">

Do you see the issue?

  1. Error:

#header or one of its children should be at the top of the viewport even after scrolling : expected 492 to be close to 0 +/- 15

Code:

<header id="header">
  <div>
   <nav id="nav-bar">
      <ul class="nav-list">
        <li class="nav-link"><a href="#home">Home</a></li>
        <li class="nav-link"><a href="#courses">Courses</a></li>
        <li class="nav-link"><a href="#contact">Contact</a></li>
      </ul>
    </nav> 
  </div>
       
<img class="logo" id="header-img" src="https://www.scottishbaristaacademy.com/wp-content/uploads/2017/03/sbaLogo.png" alt="barista logo">
  
</header>

The issue is the image and #header

Hope this helps

3

thank you, I really appreciate it.
finally fixed them.
about the color changing in the “submit” button, you also know how to fix it?
edit: fixed it too!

1 Like