Learn Intermediate OOP by Building a Platformer Game - Step 25

JavaScript
1

Tell us what’s happening:

Hi, I’m pretty sure this is a bug. Instructions say:

Create an empty if statement that checks if the sum of the player’s y position, height, and y velocity is less than or equal to the height of the canvas.

And as you can see in the code, I’ve placed them in a different order than it dictates, and it’s “wrong”. If you put them in that order, then it checks as the right answer.

Your code so far

/* file: script.js */
const startBtn = document.getElementById("start-btn");
const canvas = document.getElementById("canvas");
const startScreen = document.querySelector(".start-screen");
const checkpointScreen = document.querySelector(".checkpoint-screen");
const checkpointMessage = document.querySelector(".checkpoint-screen > p");
const ctx = canvas.getContext("2d");
canvas.width = innerWidth;
canvas.height = innerHeight;
const gravity = 0.5;
let isCheckpointCollisionDetectionActive = true;

const proportionalSize = (size) => {
  return innerHeight < 500 ? Math.ceil((size / 500) * innerHeight) : size;
}

class Player {
  constructor() {
    this.position = {
      x: proportionalSize(10),
      y: proportionalSize(400),
    };
    this.velocity = {
      x: 0,
      y: 0,
    };
    this.width = proportionalSize(40);
    this.height = proportionalSize(40);
  }
  draw() {
    ctx.fillStyle = "#99c9ff";
    ctx.fillRect(this.position.x, this.position.y, this.width, this.height);
  }
  

// User Editable Region


  update() {
    this.draw();
    this.position.x += this.velocity.x;
    this.position.y += this.velocity.y;
    if (this.velocity.y + this.position.y + this.height  <= canvas.height) {

    }
  }


// User Editable Region


}

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/122.0.0.0 Safari/537.36

Challenge Information:

Learn Intermediate OOP by Building a Platformer Game - Step 25

2

Agreed, this is a bug in the tests. Do you feel like opening a github issue for it?

2 Likes
3

I’m on it, thanks for the input!

4

It is already solved! :slightly_smiling_face: