Learn Regular Expressions by Building a Password Generator - Step 61

Tell us what’s happening:

I already search the correct code but still says “You should have break inside your new if block” what is wrong on that code?

if all(constraint <= len(re.findall(pattern, password)) for constraint, pattern in constraints):
break

Your code so far

import re
import secrets
import string


def generate_password(length, nums, special_chars, uppercase, lowercase):
    # Define the possible characters for the password
    letters = string.ascii_letters
    digits = string.digits
    symbols = string.punctuation

    # Combine all characters
    all_characters = letters + digits + symbols

    while True:
        password = ''
        # Generate password
        for _ in range(length):
            password += secrets.choice(all_characters)
       
        constraints = [
            (nums, r'\d'),
            (lowercase, r'[a-z]'),
            (uppercase, r'[A-Z]'),            
            (special_chars, fr'[{symbols}]')            
        ]

        # Check constraints
        count = 0

# User Editable Region

        if all(constraint <= len(re.findall(pattern, password)) for constraint, pattern in constraints):
            break


# User Editable Region

            break

    return password

# new_password = generate_password(8)
# print(new_password)

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/123.0.0.0 Safari/537.36

Challenge Information:

Learn Regular Expressions by Building a Password Generator - Step 61

It’s cause for step 61 you “pass an empty list as the argument to the function call.”
you are currently passing the following as the argument:

constraint <= len(re.findall(pattern, password)) for constraint, pattern in constraints

so remove that and just put an empty list there, and you should be good to go!

did you mean this?

if all():
break

If the weird square in your answer is [] then yes (i see now that if they aren’t formatted as code they make a square)

it still wrong " You should have break inside your new if body."

Yeah but you already have break inside the if body. Maybe it’s cause you have 2 break calls in your attached code? Remove one and see what happens. Also make sure it’s indented right, i.e.

if all([]):
    break

You won’t need to write break because it’s already there.

As @rustedviking mentions, now you have 2 breaks

2 Likes