When I first did this pen I forgot to modify the size of the picture in relevance to the screen width. I hope that now it is ok. I used @media (max-width: … px) to achieve it.
Hey Karlo,
nice to meet you!
great work, not much to add!
My ideas:
-
you can run the FCC tests by adding
<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>to the top of your HTML file -
you can increase the readability of your code by:
- clicking on the small arrow on the right side of the code box and
- clicking
Format HTML/CSS
Keep us posted and keep up the good work!
I noticed you used percentages in your CSS grid. I think you would be better getting into the habit of using the fr (Fractional Unit) method as I think percentages can play havoc with CSS grid when you set grid-grid gaps and stuff like that.
I will experiment with it. Thank you for your advice.
- As noted, please keep the test script when forking the pen (
<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>).- The test script should be included, with all tests passing, when you submit your projects.
- Your page passes 8/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
- Review the lesson about giving meaningful text to links.
- Web Accessibility in Mind has a more thorough explanation.
- “wikipedia entry” is not accessible
1 Like
What do you mean wikipedia entry not accessible
Ooooh now I get it. I shall fix it.
1 Like