My First Project(Tribute Page) For Review

Code Feedback
1

Hi all…this is my first project…please review and share your views to help me improve.
https://codepen.io/ajay-codepen/pen/LYZqyoj

2

Hello,
Good work !
Just one thing, i’m unable to see this part at the bottom of your page…

Capture d’écran 2020-11-15 005145
Capture d’écran 2020-11-15 005145699×128 18.6 KB

It seems to be out of canvas.

3

Welcome to the forums @a_parekh2006. Your page looks good. Some things to revisit;

  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • In addition to being used incorrectly, do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
  • Accessibility is about being accessible to all users. Review the lesson about giving meaningful text to links.
  • Within codepen, click on the down arrows in both the HTML and CSS sections and click on “format”.
    • Notice how it makes your code easier to read. You should strive to write your code like this.
5

Thanks…will look into it and do the needful.

6

Thanks… your feedback is appreciated… will look into it and rectify.

7

Thanks…have to improve though.

8

Hi…i have rectified the mistakes and reposted here.
https://codepen.io/ajay-codepen/pen/LYZqyoj
Please review. Thanks in advance.

9

Hi…I have rectified my project. Please review and comment.
https://codepen.io/ajay-codepen/pen/LYZqyoj

10

Narrow your browser as far as it will go. You see how tiny the image at the top gets? I can’t really read the text in the image at that size. But you have room on both sides so it could (and should) be bigger. Take advantage of responsiveness to allow your image to be as big as possible in narrow view ports.

UPDATE: I see you have created two threads for this same page. I don’t think they want you to do that.

11

@a_parekh2006 Looks nice and responsive. Like @bbsmooth said though the image does get a little hard to read on a smaller screen. Just something to look at. Happy Coding! :smile:

12

Hi Bruce…thanks for your comments…I have now set the min-width of the top image…I think it should solve the problem as mentioned by you…also, increasing the width of the image would also have increased the height, resulting in occupying majority of the portion of the screen on initial loading…please review and comment…

13

Hi Landon…I have tried to do the needful…hope it works…thanks for your comments.

14

Hi…I have tried to improve the page…thanks for your comments.

15

Hi Nicolas…I have tried to increase the space at bottom…thanks for your comments.

1 Like