My I have feedback on my Tribute Page project, please?

Code Feedback
1

Hey, guys,

Could you please give me your feedback on my Tribute Page project?

Here is my HTML structure:

<!DOCTYPE html>
<html lang="en">
   <head>
      <meta charset="utf-8" />
      <link rel="stylesheet" href="styles.css">
      <title>Dr. Norman Borlaug Tribute Page</title>
   </head>
   <body>
      <main id="main">
         <h1 id="title">Dr. Norman Borlaug</h1>
         <p id="title-description">The man who saved a billion lives</p>
         <figure id="img-div">
            <img id="image" src="https://assets.codepen.io/8765668/tribute-page-main-image.jpg?format=auto" alt="">
            <figcaption id="img-caption">
               Dr. Norman Borlaug, third from the left, trains biologists in Mexico on how to increase wheat yields - part of his life-long war on hunger.
            </figcaption>
         </figure>
         <section id="tribute-info">
            <h2 id="info-title">Here's a time line of Dr. Borlaug's live:</h2>
            <ul id="time-line">
               <li>
                  <strong>1914</strong> - Born in Cresco, Iowa
               </li>
               <li>
                  <strong>1933</strong> - Leaves his family's farm to attend the University of Minnesota, thanks to a Depression era program known as the "National Youth Administration"
               </li>
               <li>
                  <strong>1935</strong> - Has to stop school and save up more money. Works in the Civilian Conservation Corps, helping starving Americans. "I saw how food changed them", he said. "All of this left scars on me."
               </li>
               <li>
                  <strong>1937</strong> - Finishes university and takes a job in the US Forestry Service
               </li>
               <li>
                  <strong>1938</strong> - Marries wife of 69 years Margret Gibson. Gets laid off due to budget cuts. Inspired by Elvin Charles Stakman, he returns to school study under Stakman, who teaches him about breeding pest-resistent plants.
               </li>
               <li>
                  <strong>1941</strong> - Tries to enroll in the military after the Pearl Harbor attack, but is rejected. Instead, the military asked his lab to work on waterproof glue, DDT to control malaria, disinfectants, and other applied science.
               </li>
               <li>
                  <strong>1942</strong> - Receives a Ph.D. in Genetics and Plant Pathology
               </li>
               <li>
                  <strong>1944</strong> - Rejects a 100% salary increase from Dupont, leaves behind his pregnant wife, and flies to Mexico to head a new plant pathology program. Over the next 16 years, his team breeds 6,000 different strains of disease resistent wheat - including different varieties for each major climate on Earth.
               </li>
               <li>
                  <strong>1945</strong> - Discovers a way to grown wheat twice each season, doubling wheat yields
               </li>
               <li>
                  <strong>1953</strong> - crosses a short, sturdy dwarf breed of wheat with a high-yeidling American breed, creating a strain that responds well to fertilizer. It goes on to provide 95% of Mexico's wheat.
               </li>
               <li>
                  <strong>1962</strong> - Visits Delhi and brings his high-yielding strains of wheat to the Indian subcontinent in time to help mitigate mass starvation due to a rapidly expanding population
               </li>
               <li>
                  <strong>1970</strong> - receives the Nobel Peace Prize
               </li>
               <li>
                  <strong>1983</strong> - helps seven African countries dramatically increase their maize and sorghum yields
               </li>
               <li>
                  <strong>1984</strong> - becomes a distinguished professor at Texas A&M University
               </li>
               <li>
                  <strong>2005</strong> - states "we will have to double the world food supply by 2050." Argues that genetically modified crops are the only way we can meet the demand, as we run out of arable land. Says that GM crops are not inherently dangerous because "we've been genetically modifying plants and animals for a long time. Long before we called it science, people were selecting the best breeds."
               </li>
               <li>
                  <strong>2009</strong> - dies at the age of 95.
               </li>
            </ul>
            <blockquote id="blockquote">
               <p>"Borlaug's life and achievement are testimony to the far-reaching contribution that one man's towering intellect, persistence and scientific vision can make to human peace and progress."</p>
               <cite>-- Indian Prime Minister Manmohan Singh
               </cite>
            </blockquote>
            <h2 id="link-title">If you have time, you should read more about this incredible human being on his <a id="tribute-link" href="https://www.freecodecamp.org/learn/2022/responsive-web-design/build-a-tribute-page-project/build-a-tribute-page#" target="_blank">Wikipedia entry</a>.</h2>
         </section>
      </main>
   </body>
</html>

And here is my CSS style sheet:

* {
  /* get rid of the browser default margin and padding */
  margin: 0;
  padding: 0;
}

body {
  font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto",
    "Helvetica Neue", Arial, sans-serif;
  margin: 30px 15px;
  color: #333;
  font-size: 16px;
  min-height: 100vh;
}

#title {
  padding: 40px 0 20px 0;
}

#title-description {
  padding-bottom: 20px;
}

#img-caption {
  padding: 20px 0;
}

#info-title {
  padding: 50px 0 30px 0;
}

#main {
  background: #eee;
  border-radius: 6px;
  margin: 0 auto;
}

#img-div {
  background-color: white;
  margin: 0 30px 0 30px;
}

#image {
  display: block;
  max-width: 100%;
  height: auto;
  margin: 0 auto;
}

#title,
#title-description,
#img-caption,
#section-title,
#info-title,
#link-title {
  text-align: center;
}

#time-line,
#blockquote {
  /* border: 1px solid black; */
  width: 80%;
  max-width: 550px;
  margin: 0 auto;
}

/* li,
#link-title,
#img-div 
 {
border: 1px solid black;
} */

#time-line li,
#link-title,
#blockquote,
#info-title {
  margin-bottom: 15px;
}

Cheers in advance .

2

Gosh, I already noticed a little something to improve.

#img-div {
background-color: white;
margin: 0 30px 0 30px;
}

can be tidied up to

#img-div {
background-color: white;
margin: 0 30px;
}
3

HI @wpdevstudent !

I think your project looks good. :+1:

I would suggest utilizing classes more.
For instance, you have this selector here in your CSS

#title,
#title-description,
#img-caption,
#section-title,
#info-title,
#link-title {
  text-align: center;
}

Instead of using a list of ids, you can instead create a class and apply that to the elements you want to have centered text

Hope that helps :+1:

1 Like
4

Thank you for chipping in, J,

I fully agree with you and would rather use classes in this projects.

The thing is using id’s is mandatory:

1. Your tribute page should have a main element with a corresponding id of main, which contains all other elements
2. You should see an element with an id of title, which contains a string (i.e. text), that describes the subject of the tribute page (e.g. "Dr. Norman Borlaug")
3. You should see either a figure or a div element with an id of img-div
4. Within the #img-div element, you should see an img element with a corresponding id="image"
5. Within the #img-div element, you should see an element with a corresponding id="img-caption" that contains textual content describing the image shown in #img-div
6. You should see an element with a corresponding id="tribute-info", which contains textual content describing the subject of the tribute page
7. You should see an a element with a corresponding id="tribute-link", which links to an outside site, that contains additional information about the subject of the tribute page. HINT: You must give your element an attribute of target and set it to _blank in order for your link to open in a new tab
8. Your #image should use max-width and height properties to resize responsively, relative to the width of its parent element, without exceeding its original size
9. Your img element should be centered within its parent element

Fulfill the user stories and pass all the tests below to complete this project. Give it your own personal style. Happy Coding!

Thanks once again.

5

They are mandatory to add for the HTML elements.
But that doesn’t stop you from also adding a class to those elements too :+1:

Then you can use that class in your css :+1:

.text-center {
  text-align: center;
}

and it still passes

Screenshot 2025-02-02 at 11.05.38 AM
Screenshot 2025-02-02 at 11.05.38 AM1878×1230 209 KB

1 Like
6

Thanks, I’ll play with it.

7

Done.

Thanks, J :slight_smile:

You are correct. Replacing those several id’s with just one class made that part of my CSS a bit tidier.

1 Like
8

you should do the Tribute page on a subject of your choice not on the same subject of the example page