My Label elements already have closing tags

Tell us what’s happening:
I essentially added the Input elements correctly in the proper format and for some reason when I ran the check, it told me that my label needs a closing tag. But I looked at it and I see that I already have closing tags on both indoor and outdoor formats.
Your code so far


Indoor


Outdoor


<h2>CatPhotoApp</h2>
<main>
<p>Click here to view more <a href="#">cat photos</a>.</p>

<a href="#"><img src="https://bit.ly/fcc-relaxing-cat" alt="A cute orange cat lying on its back."></a>

<p>Things cats love:</p>
<ul>
  <li>cat nip</li>
  <li>laser pointers</li>
  <li>lasagna</li>
</ul>
<p>Top 3 things cats hate:</p>
<ol>
  <li>flea treatment</li>
  <li>thunder</li>
  <li>other cats</li>
</ol>
<form action="https://freecatphotoapp.com/submit-cat-photo">
  <input type="text" placeholder="cat photo URL" required>
  <button type="submit">Submit</button>
  <label for="indoor">
    <input id="indoor" type="radio" name=“indoor-outdoor”>Indoor</label>
  <label for="outdoor">
    <input id="outdoor" type="radio" name="indoor-outdoor">Outdoor</label>
</form>
</main>
  **Your browser information:**

User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.1.2 Safari/605.1.15.

Challenge: Create a Set of Radio Buttons

Link to the challenge:

Hi there. What exactly do all of the failing tests say?

It says " Each of your label elements should have a closing tag."

<label for="indoor"> 
  <input id="indoor" type="radio" name="indoor-outdoor">Indoor 
</label>

I’m over here trying to play spot the difference between yours and the example and not seeing it quite yet.

These quotes look different from the others :grinning:

1 Like

Which is really odd in my opinion, I keep running the test and it tells me the same thing

Ah ha! Well spotted!

1 Like

I’m still not understanding unfortunately :S

Those quotes are not the standard quotes here “”
Use the standard quotes “” and the test will pass.
You use them everywhere in your code except here

Oh dear, I still see no way of fixing it. deleted it and re-inputted the same quotes and it still says each label element should have a closing tag :frowning:

That’s weird because you wrote with the correct quotes here
type="radio" name="indoor-outdoor">

It was just this one that was wrong.

What device are you using?

I’m currently using a MacBook Pro

Yep. Apple sometimes refuses to let you choose your punctuation. There should be a setting for you to turn off ‘smart punctuation’ somewhere.

You can also copy-paste the correct quotes in place of the bad ones.

2 Likes

I tried copying and pasting and it still doesn’t work. If I “reset all code” would that reset just that one lesson i’m doing? or would it reset the whole course?

Resetting applies only to the current challenge.

1 Like

I reset the current challenge and redid it, and even disabled the ‘smart punctuation’ and it worked!! thank you for your help :smiley:

2 Likes

Huzzah!

1 Like